Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retain all fields during ServiceOptions.tobuilder #2822

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

burkedavison
Copy link
Contributor

See #2821

This PR originally created to ensure headerProvider is correctly copied, but expanded to ensure all fields are used in equals and hashCode comparisons for the associated copy tests.

@burkedavison burkedavison requested a review from a team as a code owner May 24, 2024 20:46
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 24, 2024
Copy link

sonarcloud bot commented May 24, 2024

Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@burkedavison
Copy link
Contributor Author

Downstream checks failing on serialization tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant