Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add junit5 extension to setup environment variable #2799

Merged
merged 9 commits into from
May 23, 2024
Merged

chore: add junit5 extension to setup environment variable #2799

merged 9 commits into from
May 23, 2024

Conversation

JoeWang1127
Copy link
Collaborator

@JoeWang1127 JoeWang1127 commented May 22, 2024 •
edited
Loading

Fix: #2785.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 22, 2024
JoeWang1127
JoeWang1127 commented May 23, 2024
View reviewed changes
.github/workflows/ci.yaml
env:
GOOGLE_CLOUD_UNIVERSE_DOMAIN: random.com
-Djvm="${JAVA8_HOME}/bin/java" \
-DargLine="-Djava.util.logging.SimpleFormatter.format='%1$tY %1$tl:%1$tM:%1$tS.%1$tL %2$s %4$s: %5$s%6$s%n'"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overwrite argLine because Java 8 doesn't support --add-opens.

@JoeWang1127 JoeWang1127 marked this pull request as ready for review May 23, 2024 12:31
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner May 23, 2024 12:31
lqiu96
lqiu96 approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@lqiu96 lqiu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@JoeWang1127 JoeWang1127 merged commit 599f5da into main May 23, 2024
48 checks passed
@JoeWang1127 JoeWang1127 deleted the chore/add-junit5-extension branch May 23, 2024 19:15
lqiu96 pushed a commit that referenced this pull request May 23, 2024
@JoeWang1127 @lqiu96
chore: add junit5 extension to setup environment variable (#2799)
7b494c6 
Fix: #2785.
JoeWang1127 added a commit that referenced this pull request May 24, 2024
@JoeWang1127
Revert "chore: add junit5 extension to setup environment variable (#2799
89be931 
)"

This reverts commit 599f5da.
@JoeWang1127 JoeWang1127 mentioned this pull request May 24, 2024
Merged
JoeWang1127 added a commit that referenced this pull request May 24, 2024
@JoeWang1127
Revert "chore: add junit5 extension to setup environment variable" (#…
3ba43c3 
…2817)

Reverts #2799 since `junit-pioneer` is not
compatible with Java 8.
@JoeWang1127 JoeWang1127 mentioned this pull request May 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqiu96 lqiu96 lqiu96 approved these changes

@blakeli0 blakeli0 Awaiting requested review from blakeli0

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update environment variable unit tests with Junit 5 features.
2 participants
@JoeWang1127 @lqiu96