chore: add integration test running in docker container #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
|
I'll remove this cloud build trigger once the PR is approved. |
JoeWang1127
commented
Apr 2, 2024
| ) | ||
|
|
||
| @classmethod | ||
| def __run_entry_point_in_docker_container( |
There was a problem hiding this comment.
After creating entry_point.py, there will be only once docker run.
blakeli0
reviewed
Apr 2, 2024
| build_file = os.path.join( | ||
| repo_root_dir, ".cloudbuild", "library_generation", "library_generation.Dockerfile" | ||
| ) | ||
| image_tag = f"test-image:latest" |
There was a problem hiding this comment.
We don't have to use f string as this is a hardcoded value.
| ) | ||
| os.remove(f"{description_file}") | ||
| def test_entry_point_running_in_container(self): | ||
| self.__build_image(docker_file=build_file, tag=image_tag, cwd=repo_root_dir) |
There was a problem hiding this comment.
Unless we want to expose tag as a parameter of IntegrationTest in the future, I don't think we need to pass around tag in this script, we can always use image_tag.
blakeli0
approved these changes
Apr 2, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
generate_repo.pyandgenerate_pr_description.pyin docker container.Context:
In this log, the nightly generation job only took 3 mins. After investigation, we found out that removing
mainmethod ingenerate_repo.py(#2598) caused the CLI is not running despite that the job returns successfully.This non-explicit failure demonstrated that there's difference between calling CLI (
generatemethod ingenerate_repo.py) and its implementation (generate_from_yamlmethod ingenerate_repo.py).We decided to change the integration test to run the CLI in docker container, rather than testing
generate_from_yamlbecause it is the containerized CLI will be used in downstream libraries.