chore: use template excludes in generation config #2453
Conversation
product-auto-label
bot
added
size: m
product-auto-label
bot
added
size: l
JoeWang1127
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
| @@ -54,8 +54,8 @@ def generate_composed_library( | |||
| :param library_path: the path to which the generated file goes | |||
| :param library: a LibraryConfig object contained inside config, passed here | |||
| for convenience and to prevent all libraries to be processed | |||
| :param output_folder: | |||
| :param versions_file: | |||
| :param output_folder: the folder to where tools go | |||
There was a problem hiding this comment.
Later, we should consider renaming this folder because it is not where we create the resulting library/repo (which is the actual output of the script (?))
There was a problem hiding this comment.
I agree, the name is a bit of confusing.
Do you have a better name in mind?
There was a problem hiding this comment.
Although anything created by the script is output, in a functional perspective the output we care about is the one we have a final use for. Just clarifying this rationale because "anything is output" can be valid too (and this is more of a suggestion in the end).
There was a problem hiding this comment.
Thanks. I'll keep it as-is for now (I need sometime to think of a better name).
We can come up with a new name later.
There was a problem hiding this comment.
I agree, the name is a bit of confusing.
Do you have a better name in mind?
I find it slightly tough to answer. What about workspace?
There was a problem hiding this comment.
Yeah, this sounds good.
| @@ -104,6 +105,97 @@ def test_eprint_valid_input_succeeds(self): | |||
| # print() appends a `\n` each time it's called | |||
| self.assertEqual(test_input + "\n", result) | |||
|
|
|||
| # parameterized tests need to run from the class, see | |||
| # https://github.com/wolever/parameterized/issues/37 for more info. | |||
There was a problem hiding this comment.
| # https://github.com/wolever/parameterized/issues/37 for more info. | |
| # https://github.com/wolever/parameterized/issues/37 for more info. | |
| # This test confirms that a ValueError with an error message about a missing key (specified in the first parameter of each `parameterized` tuple) when parsing a test configuartion yaml (second parameter) will be raised. |
|
|
In this PR: - Modify `generate_prerequisite_files` to render `owlbot.py` using template excludes from `GenerationConfig`, rather than hard code the excludes. - Add unit tests to verify `from_yaml` method.
In this PR:
generate_prerequisite_filesto renderowlbot.pyusing template excludes fromGenerationConfig, rather than hard code the excludes.from_yamlmethod.