-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update protobuf dependencies to v3.22.3 #1369
deps: update protobuf dependencies to v3.22.3 #1369
Conversation
As discussed with @suztomo, do not merge this until googleapis updates the protobuf compiler version to 3.22. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
until googleapis updates the protobuf compiler version to 3.22.
Waiting for https://github.com/googleapis/googleapis/blob/master/WORKSPACE#L83 to have Protobuf 3.22.0 or higher. |
b24e0d0
to
402ed10
Compare
@blakeli0 @meltsufin Now the two files (pom.xml and dependencies.properties) are managed by one pull request. Thank you for the pointer today. But "ci-maven / build" started failing.
The strange "$" mark seems related to this issue protocolbuffers/protobuf#12170 |
402ed10
to
4a3f641
Compare
[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
build --cxxopt=-std=c++14 | ||
build --host_cxxopt=-std=c++14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From protocolbuffers/protobuf#12393 to resolve "C++ versions less than C++14 are not supported."
As of the 4/25 release cycle, the protobuf version in googleapis is Keeping this as |
As of the 5/8 release cycle, the protobuf version in googleapis is 3.21.12: https://github.com/googleapis/googleapis/blame/master/WORKSPACE#L162 Keeping this as Do not merge. |
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@mpeddada1 Can you bump the version to 3.23.1? |
PR to bump version to 3.23.1 created at #1698 |
This PR contains the following updates:
3.21.10
->3.22.2
3.21.12
->3.22.2
⚠ Dependency Lookup Warnings ⚠
Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.
Release Notes
protocolbuffers/protobuf
v3.22.2
Compare Source
v3.22.1
Compare Source
v3.22.0
Compare Source
v3.21.12
Compare Source
v3.21.11
Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.