Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make library generation unit tests a required check gets stuck on child jobs #2733

Closed
JoeWang1127 opened this issue May 5, 2024 · 2 comments · Fixed by #3142
Closed

Make library generation unit tests a required check gets stuck on child jobs #2733

JoeWang1127 opened this issue May 5, 2024 · 2 comments · Fixed by #3142
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@JoeWang1127
Copy link
Collaborator

The library-generation-unit-tests sprouts two jobs: library-generation-unit-tests (8, macos-12) and library-generation-unit-tests (8, ubuntu-22.04).

The behavior of this check when setting library-generation-unit-tests (the parent job) as required:

  • On pull request that doesn't change library_generation directory: checks initiate and return result.
  • On pull request that changes library_generation directory: library-generation-unit-tests is stuck.

The behavior of this check when setting two child jobs as required:

  • On pull request that doesn't change library_generation directory: library-generation-unit-tests (8, macos-12) and library-generation-unit-tests (8, ubuntu-22.04) are stuck.
  • On pull request that changes library_generation directory: checks initiate and return result.

The behavior of this check when setting parent and two child jobs as required:

  • On pull request that doesn't change library_generation directory: library-generation-unit-tests (8, macos-12) and library-generation-unit-tests (8, ubuntu-22.04) are stuck.
  • On pull request that changes library_generation directory: library-generation-unit-tests is stuck.
@JoeWang1127 JoeWang1127 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 5, 2024
@JoeWang1127
Copy link
Collaborator Author

A potential solution: remove unit tests on macos since it adds little value.

@blakeli0 blakeli0 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jul 30, 2024
@zhumin8 zhumin8 assigned zhumin8 and unassigned zhumin8 Aug 1, 2024
@zhumin8 zhumin8 changed the title Make library generation unit tests a required check Make library generation unit tests a required check gets stuck on child jobs Aug 6, 2024
@zhumin8 zhumin8 mentioned this issue Aug 6, 2024
Closed
@suztomo
Copy link
Member

suztomo commented Aug 28, 2024

Required checks that only run on certain path changes are discussed in https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks. I don't see we use the workaround.

@JoeWang1127 JoeWang1127 mentioned this issue Aug 29, 2024
Merged
ldetmer pushed a commit that referenced this issue Sep 17, 2024
@JoeWang1127 @ldetmer
chore: remove mac unit tests in library generation ci (#3142)
a55031e 
Fix: #2733 

The checks change to
<img width="735" alt="image"
src="https://github.com/user-attachments/assets/5b89dd78-2338-4412-93e1-6dc2ffdb487c">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove mac unit tests in library generation ci googleapis/sdk-platform-java
4 participants
@suztomo @zhumin8 @blakeli0 @JoeWang1127