Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow remotes that don't end in .git #92

Merged
merged 2 commits into from
Oct 31, 2018
Merged

Allow remotes that don't end in .git #92

merged 2 commits into from
Oct 31, 2018

Conversation

kjin
Copy link
Contributor

@kjin kjin commented Oct 26, 2018

Fixes #90

Just a heads up, I'm not really familiar with Python, so I wasn't able to check whether this Regex change does what I expect.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 26, 2018
@busunkim96 busunkim96 requested a review from theacodes October 30, 2018 19:28
@busunkim96 busunkim96 merged commit ac8c253 into googleapis:master Oct 31, 2018
@kjin
Copy link
Contributor Author

kjin commented Oct 31, 2018

@busunkim96 thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes theacodes approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kjin @theacodes @googlebot @busunkim96