Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ruby start#determine_last_release #184

Merged
merged 1 commit into from
May 2, 2019

Conversation

quartzmo
Copy link
Member

@quartzmo quartzmo commented May 2, 2019

Add slash separator (/) to ensure match string represents entire package name, to fix a bug in which tags for other packages (ex: "google-cloud-spanner") were returned for the "google-cloud" package, since its name is a subset.

[fixes #182]

I ran this branch locally to produce googleapis/google-cloud-ruby#3282

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 2, 2019
Copy link

@blowmage blowmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but I'm not familiar enough with this to give it a knowledgable approval.

@busunkim96 busunkim96 merged commit 599acf1 into googleapis:master May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruby: Incorrect version bump
5 participants