Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare ruby for autorelease #151

Merged
merged 4 commits into from
Jan 17, 2019
Merged

prepare ruby for autorelease #151

merged 4 commits into from
Jan 17, 2019

Conversation

TheRoyalTnetennba
Copy link
Contributor

@TheRoyalTnetennba TheRoyalTnetennba commented Jan 16, 2019 •
edited
Loading

Allow autorelease to handle gemspecs that contain version directly rather than in version.rb.

Setup non-interactive mode for releasetool tag

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 16, 2019
busunkim96
busunkim96 approved these changes Jan 16, 2019
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Note that Autorelease pulls from releasetool's master branch, so you may want to wait to merge it. 😸

quartzmo
quartzmo approved these changes Jan 17, 2019
View reviewed changes
Copy link
Member

@quartzmo quartzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I did not manually test it.

@TheRoyalTnetennba TheRoyalTnetennba merged commit 821c1af into master Jan 17, 2019
@TheRoyalTnetennba TheRoyalTnetennba deleted the ruby-autorelease branch January 17, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@quartzmo quartzmo quartzmo approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheRoyalTnetennba @quartzmo @busunkim96 @googlebot