Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add retry conf test cases for conditionally idempotent operations with no preconditions #566

Merged
merged 4 commits into from
Sep 2, 2021

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Sep 1, 2021

This adds test cases to the retry strategy conformance tests:

  • Scenario 3 - for conditionally idempotent operations with retryable error codes, libraries don't retry when preconditions are absent
  • Add test schema for scenario 3 and align json file with conformance-tests/retry_tests.json

@cojenco cojenco requested a review from a team September 1, 2021 00:55
@cojenco cojenco requested a review from a team as a code owner September 1, 2021 00:55
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Sep 1, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 1, 2021
@cojenco cojenco added the automerge Merge the pull request once unit tests and other checks pass. label Sep 2, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 3a489ad into googleapis:main Sep 2, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 2, 2021
@cojenco cojenco deleted the s3-retry31 branch September 17, 2021 21:00
cojenco added a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
…ons with no preconditions (googleapis#566)

This adds test cases to the retry strategy conformance tests:

- Scenario 3 - for conditionally idempotent operations with retryable error codes, libraries **don't** retry when preconditions are absent
- Add test schema for scenario 3 and align json file with [conformance-tests/retry_tests.json](https://github.com/googleapis/conformance-tests/blob/master/storage/v1/retry_tests.json)
cojenco added a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
…ons with no preconditions (googleapis#566)

This adds test cases to the retry strategy conformance tests:

- Scenario 3 - for conditionally idempotent operations with retryable error codes, libraries **don't** retry when preconditions are absent
- Add test schema for scenario 3 and align json file with [conformance-tests/retry_tests.json](https://github.com/googleapis/conformance-tests/blob/master/storage/v1/retry_tests.json)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants