Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpannerDialect does not register RETURNING as supported for insert, update, delete #498

Closed
olavloite opened this issue Nov 7, 2024 · 0 comments · Fixed by #503
Closed

SpannerDialect does not register RETURNING as supported for insert, update, delete #498

olavloite opened this issue Nov 7, 2024 · 0 comments · Fixed by #503
Assignees
@olavloite
Labels
api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@olavloite
Copy link
Contributor

The following should be added to the SpannerDialect class:

    insert_returning = True
    update_returning = True
    delete_returning = True
@olavloite olavloite added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Nov 7, 2024
@olavloite olavloite self-assigned this Nov 7, 2024
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. label Nov 7, 2024
olavloite added a commit that referenced this issue Nov 8, 2024
@olavloite
fix: support THEN RETURN for insert, update, delete
7e8f0bd 
Support THEN RETURN clauses for INSERT, UPDATE, and DELETE statements.

Fixes #498
@olavloite olavloite mentioned this issue Nov 8, 2024
Merged
olavloite added a commit that referenced this issue Nov 28, 2024
@olavloite
fix: support THEN RETURN for insert, update, delete (#503)
ac64472 
* fix: support THEN RETURN for insert, update, delete

Support THEN RETURN clauses for INSERT, UPDATE, and DELETE statements.

Fixes #498

* test: override insert auto-generated pk test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olavloite olavloite

Labels
api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: support THEN RETURN for insert, update, delete googleapis/python-spanner-sqlalchemy
1 participant
@olavloite