Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: add type hints to all samples #476

Merged
merged 11 commits into from
Aug 25, 2021
Merged

samples: add type hints to all samples #476

merged 11 commits into from
Aug 25, 2021

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Aug 24, 2021

Closes #264.

And here they are, annotated samples.

We should follow up with a pytype CI check, I'll open a separate issue for that.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut requested review from a team as code owners August 24, 2021 15:28
@plamut plamut requested a review from dandhlee August 24, 2021 15:28
@product-auto-label product-auto-label bot added api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. labels Aug 24, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2021
anguillanneuf
anguillanneuf approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you Peter!

@plamut plamut added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 25, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 25, 2021
@plamut
Copy link
Contributor Author

plamut commented Aug 25, 2021

I will follow up with adding pytype checks to leverage these type annotations and the ones we'll add to the code in the future (#477).

@gcf-merge-on-green gcf-merge-on-green bot merged commit 1164890 into googleapis:master Aug 25, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 25, 2021
@plamut plamut deleted the iss-264 branch August 25, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguillanneuf anguillanneuf anguillanneuf approved these changes

@dandhlee dandhlee Awaiting requested review from dandhlee

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

samples: add type hints to all samples
3 participants
@plamut @anguillanneuf @yoshi-kokoro