Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: require grpcio >= 1.38.1 to prevent a possible crash #435

Merged
merged 1 commit into from
Jul 1, 2021
Merged

fix: require grpcio >= 1.38.1 to prevent a possible crash #435

merged 1 commit into from
Jul 1, 2021

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Jun 28, 2021

Fixes #414.

See the issue comment for more info.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut requested a review from a team as a code owner June 28, 2021 15:30
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Jun 28, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 28, 2021
@plamut plamut changed the title chore: require grpcio >= 1.38.1 fix: require grpcio >= 1.38.1 Jun 29, 2021
@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 29, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 29, 2021
@plamut plamut changed the title fix: require grpcio >= 1.38.1 fix: require grpcio >= 1.38.1 to prevent a possible crash Jun 29, 2021
@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2021
@plamut
Copy link
Contributor Author

plamut commented Jul 1, 2021

Thanks for approving, will release a new version on Monday.

@plamut plamut merged commit afd10c8 into googleapis:master Jul 1, 2021
@plamut plamut deleted the iss-414 branch July 1, 2021 17:42
@g1bs0nsg g1bs0nsg mentioned this pull request Jul 24, 2021
Closed
@nathanmrtns
Copy link
Contributor

nathanmrtns commented Mar 9, 2022 •
edited
Loading

@plamut @pradn

Is it possible to increase grpcio version to 1.44.0?
There is a whole problem with Mac M1 that grpcio fails when trying to install version 1.38.1. It seems to be fixed on 1.44.0 because I've been able to install without problems.

@acocuzzo acocuzzo mentioned this pull request Mar 9, 2022
Closed
@acocuzzo
Copy link
Contributor

acocuzzo commented Mar 9, 2022

Hey @nathanmrtns thanks for bringing this to our attention, investigating and filling #609 to track.

@ponponon ponponon mentioned this pull request Jun 13, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradn pradn pradn approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crash: free(): invalid pointer
5 participants
@plamut @nathanmrtns @acocuzzo @pradn @yoshi-kokoro