Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add noxfile_config to samples dir #255

Merged
merged 1 commit into from
Dec 16, 2020
Merged

chore: add noxfile_config to samples dir #255

merged 1 commit into from
Dec 16, 2020

Conversation

anguillanneuf
Copy link
Contributor

@anguillanneuf anguillanneuf commented Dec 16, 2020

Use a separate project per sample test session. This file noxfile_config.py was copied from https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md#noxfile_configpy

Fixes #240
Fixes #246
Fixes #227

@anguillanneuf anguillanneuf requested a review from a team as a code owner December 16, 2020 00:51
@anguillanneuf anguillanneuf requested review from engelke and removed request for a team December 16, 2020 00:51
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Dec 16, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 16, 2020
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 16, 2020
@anguillanneuf anguillanneuf changed the title add noxfile_config to samples dir samples: add noxfile_config to samples dir Dec 16, 2020
@anguillanneuf anguillanneuf changed the title samples: add noxfile_config to samples dir chore: add noxfile_config to samples dir Dec 16, 2020
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anguillanneuf anguillanneuf merged commit 94c89bb into master Dec 16, 2020
@anguillanneuf anguillanneuf deleted the samples branch December 16, 2020 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
2 participants