Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add samples from pubsub/streaming-analytics #135

Closed
wants to merge 12 commits into from

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Jun 25, 2020

Samples from https://github.com/GoogleCloudPlatform/python-docs-samples/tree/master/pubsub/streaming-analytics

Closes #137.
Towards #131.

Question: Do we need to move these samples, too, or are those from the pubsub/cloud-client directory enough?

anguillanneuf and others added 12 commits September 26, 2019 14:48
…python-docs-samples#2385)

* Add README

* Add requirements.txt

* Add sample

* Update readme

* Working example

* Submit for review

* lint

* Remove Java links

* David's suggestions

* nits: license header, docstring, indentation

* Add a note, comments, input args, op name

* change message to str, json dumps batch

* update requirement

* Add test, should pass lint & py36

* OK to not delete topic

* use storage client

* update storage client to gcs client
…ython-docs-samples#2555)

* Update test with mock
* Clean up resources after tests
* Use unique resource names avoid test failures
* Delete subscriptions in cleanup phase
* Ensure unique topic name
* Update assert to remove bytestring notation
* Rewrite PubSubToGCS test using dataflow testing module
…ples#2806)

* chore(deps): update dependency requests to v2.23.0

* Simplify noxfile and add version control.

* Configure appengine/standard to only test Python 2.7.

* Update Kokokro configs to match noxfile.

* Add requirements-test to each folder.

* Remove Py2 versions from everything execept appengine/standard.

* Remove conftest.py.

* Remove appengine/standard/conftest.py

* Remove 'no-sucess-flaky-report' from pytest.ini.

* Add GAE SDK back to appengine/standard tests.

* Fix typo.

* Roll pytest to python 2 version.

* Add a bunch of testing requirements.

* Remove typo.

* Add appengine lib directory back in.

* Add some additional requirements.

* Fix issue with flake8 args.

* Even more requirements.

* Readd appengine conftest.py.

* Add a few more requirements.

* Even more Appengine requirements.

* Add webtest for appengine/standard/mailgun.

* Add some additional requirements.

* Add workaround for issue with mailjet-rest.

* Add responses for appengine/standard/mailjet.

Co-authored-by: Renovate Bot <bot@renovateapp.com>
…eCloudPlatform/python-docs-samples#3411)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [apache-beam](https://beam.apache.org) | minor | `==2.19.0` -> `==2.20.0` |

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Never, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/python-docs-samples).
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 25, 2020
@plamut plamut added type: process A process-related concern. May include testing, release, or the like. type: docs Improvement to the documentation for an API. and removed type: process A process-related concern. May include testing, release, or the like. labels Jun 25, 2020
@plamut plamut requested a review from busunkim96 June 25, 2020 10:46
@busunkim96
Copy link
Contributor

Question: Do we need to move these samples, too, or are those from the pubsub/cloud-client directory enough?

It looks like these might be better kept in python-docs-samples. @anguillanneuf @hongalex Could you take a look?

@anguillanneuf
Copy link
Contributor

@busunkim96 @plamut That's right. pubsub/cloud-client can be moved. But pubsub/streaming-analytics can stay with python-docs-samples.

@plamut
Copy link
Contributor Author

plamut commented Jun 26, 2020

Thanks @anguillanneuf, I'll close this PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pubsub/streaming-analytics samples from the samples repo
6 participants