Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): Increase example max_bytes setting for cloud storage subscriptions to encourage more performant subscribe #1324

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lahuang4
Copy link

No description provided.

…ubscriptions to encourage more performant subscribe
@lahuang4 lahuang4 requested review from a team as code owners January 10, 2025 00:55
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 10, 2025
@product-auto-label product-auto-label bot added api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. labels Jan 10, 2025
@mukund-ananthu mukund-ananthu enabled auto-merge (squash) January 10, 2025 01:05
@hongalex
Copy link
Member

Just noticed this sample isn't on https://cloud.google.com/pubsub/docs/create-cloudstorage-subscription

@lahuang4
Copy link
Author

@lahuang4
Copy link
Author

It looks like the Kokoro build failed, but it was a different test case which failed:

=================================== FAILURES ===================================
__________________ test_opentelemetry_flow_control_exception ___________________

...

        spans = span_exporter.get_finished_spans()
        # Span 1 = Publisher Flow Control Span of first publish
        # Span 2 = Publisher Batching Span of first publish
        # Span 3 = Publisher Flow Control Span of second publish(raises FlowControlLimitError)
        # Span 4 = Publish Create Span of second publish(raises FlowControlLimitError)
>       assert len(spans) == 4
E       assert 5 == 4
E        +  where 5 = len((, , ))

tests/unit/pubsub_v1/publisher/test_publisher_client.py:301: AssertionError

@hongalex could you help me re-run the Kokoro check? Not sure how to trigger it myself.

(Looks like there is already an issue opened for the test being flaky: #1309)

@briandorsey briandorsey added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2025
@lahuang4 lahuang4 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2025
@mukund-ananthu
Copy link
Contributor

@parthea The Owlbot PostProcessor seems to be stuck indefinitely despite multiple force-runs. Could you PTAL / is this a known issue. cc: @lahuang4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants