Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix system test under Datastore Emulator. (Fixes #118) #119

Merged
merged 3 commits into from
Jun 24, 2019
Merged

Fix system test under Datastore Emulator. (Fixes #118) #119

merged 3 commits into from
Jun 24, 2019

Commits on Jun 24, 2019

  1. Fix system test under Datastore Emulator. (Fixes googleapis#118) 

    Improve usage of Datastore Emulator by not requiring credentials to be
set.

Rewrite failing system test to work around emulator discrepency with
``more_results`` field of ``QueryResultsBatch`` message.

See: googleapis/google-cloud-datastore#130

Update the ``more`` return value of ``Query.fetch_page`` to be ``False``
if an empty page has just been retrieved. This is intended to prevent
possible infinite loops in client code when using the Datastore
emulator.
    Chris Rossi committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    3fc546f View commit details
    Browse the repository at this point in the history

  2. Fix typo.

    Chris Rossi committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    8972c73 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into fix-system-tests-w-emulator

    @crwilcox
    crwilcox authored Jun 24, 2019
    Configuration menu
    Copy the full SHA
    627eba9 View commit details
    Browse the repository at this point in the history