Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

chore: delete owlbot.py #213

Merged
merged 4 commits into from
Nov 9, 2021
Merged

chore: delete owlbot.py #213

merged 4 commits into from
Nov 9, 2021

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Oct 27, 2021

Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.

@parthea parthea requested a review from a team as a code owner October 27, 2021 11:01
@product-auto-label product-auto-label bot added the api: language Issues related to the googleapis/python-language API. label Oct 27, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 27, 2021
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be some unpublished files that result in a sphinx error:

Traceback (most recent call last):
  File "/tmpfs/src/github/python-language/.nox/docs/lib/python3.8/site-packages/sphinx/cmd/build.py", line 280, in build_main
    app.build(args.force_all, filenames)
  File "/tmpfs/src/github/python-language/.nox/docs/lib/python3.8/site-packages/sphinx/application.py", line 350, in build
    self.builder.build_update()
  File "/tmpfs/src/github/python-language/.nox/docs/lib/python3.8/site-packages/sphinx/builders/__init__.py", line 292, in build_update
    self.build(to_build,
  File "/tmpfs/src/github/python-language/.nox/docs/lib/python3.8/site-packages/sphinx/builders/__init__.py", line 328, in build
    self.env.check_consistency()
  File "/tmpfs/src/github/python-language/.nox/docs/lib/python3.8/site-packages/sphinx/environment/__init__.py", line 627, in check_consistency
    logger.warning(__('document isn\'t included in any toctree'),
  File "/usr/local/lib/python3.8/logging/__init__.py", line 1812, in warning
    self.log(WARNING, msg, *args, **kwargs)
  File "/tmpfs/src/github/python-language/.nox/docs/lib/python3.8/site-packages/sphinx/util/logging.py", line 123, in log
    super().log(level, msg, *args, **kwargs)
  File "/usr/local/lib/python3.8/logging/__init__.py", line 1844, in log
    self.logger.log(level, msg, *args, **kwargs)
  File "/usr/local/lib/python3.8/logging/__init__.py", line 1512, in log
    self._log(level, msg, args, **kwargs)
  File "/usr/local/lib/python3.8/logging/__init__.py", line 1589, in _log
    self.handle(record)
  File "/usr/local/lib/python3.8/logging/__init__.py", line 1599, in handle
    self.callHandlers(record)
  File "/usr/local/lib/python3.8/logging/__init__.py", line 1661, in callHandlers
    hdlr.handle(record)
  File "/usr/local/lib/python3.8/logging/__init__.py", line 950, in handle
    rv = self.filter(record)
  File "/usr/local/lib/python3.8/logging/__init__.py", line 811, in filter
    result = f.filter(record)
  File "/tmpfs/src/github/python-language/.nox/docs/lib/python3.8/site-packages/sphinx/util/logging.py", line 423, in filter
    raise exc
sphinx.errors.SphinxWarning: /tmpfs/src/github/python-language/docs/api.rst:document isn't included in any toctree

@parthea parthea self-assigned this Nov 3, 2021
@parthea
Copy link
Contributor Author

parthea commented Nov 4, 2021

docs/api.rst looks to be redundant now that we have docs/index.rst which is autogenerated. docs/usage.rst hasn't been updated since 2018. I'd like to remove it in favor of samples/snippets which is consistent across all googleapis/python-* repos.

@parthea
Copy link
Contributor Author

parthea commented Nov 8, 2021

This is ready for review.

@parthea
Copy link
Contributor Author

parthea commented Nov 9, 2021

@busunkim96 Please could you review/approve?

@busunkim96
Copy link
Contributor

Ah sorry, I don't think this made it through my normal filter. Could you please "re-request" a review if I've looked at a PR previously? Thanks!

@parthea parthea merged commit 9d8e5de into main Nov 9, 2021
@parthea parthea deleted the delete-owlbot-py branch November 9, 2021 18:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: language Issues related to the googleapis/python-language API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants