This repository has been archived by the owner on Sep 5, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: language
Issues related to the googleapis/python-language API.
label
Oct 27, 2021
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Oct 27, 2021
busunkim96
suggested changes
Oct 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seem to be some unpublished files that result in a sphinx error:
Traceback (most recent call last):
File "/tmpfs/src/github/python-language/.nox/docs/lib/python3.8/site-packages/sphinx/cmd/build.py", line 280, in build_main
app.build(args.force_all, filenames)
File "/tmpfs/src/github/python-language/.nox/docs/lib/python3.8/site-packages/sphinx/application.py", line 350, in build
self.builder.build_update()
File "/tmpfs/src/github/python-language/.nox/docs/lib/python3.8/site-packages/sphinx/builders/__init__.py", line 292, in build_update
self.build(to_build,
File "/tmpfs/src/github/python-language/.nox/docs/lib/python3.8/site-packages/sphinx/builders/__init__.py", line 328, in build
self.env.check_consistency()
File "/tmpfs/src/github/python-language/.nox/docs/lib/python3.8/site-packages/sphinx/environment/__init__.py", line 627, in check_consistency
logger.warning(__('document isn\'t included in any toctree'),
File "/usr/local/lib/python3.8/logging/__init__.py", line 1812, in warning
self.log(WARNING, msg, *args, **kwargs)
File "/tmpfs/src/github/python-language/.nox/docs/lib/python3.8/site-packages/sphinx/util/logging.py", line 123, in log
super().log(level, msg, *args, **kwargs)
File "/usr/local/lib/python3.8/logging/__init__.py", line 1844, in log
self.logger.log(level, msg, *args, **kwargs)
File "/usr/local/lib/python3.8/logging/__init__.py", line 1512, in log
self._log(level, msg, args, **kwargs)
File "/usr/local/lib/python3.8/logging/__init__.py", line 1589, in _log
self.handle(record)
File "/usr/local/lib/python3.8/logging/__init__.py", line 1599, in handle
self.callHandlers(record)
File "/usr/local/lib/python3.8/logging/__init__.py", line 1661, in callHandlers
hdlr.handle(record)
File "/usr/local/lib/python3.8/logging/__init__.py", line 950, in handle
rv = self.filter(record)
File "/usr/local/lib/python3.8/logging/__init__.py", line 811, in filter
result = f.filter(record)
File "/tmpfs/src/github/python-language/.nox/docs/lib/python3.8/site-packages/sphinx/util/logging.py", line 423, in filter
raise exc
sphinx.errors.SphinxWarning: /tmpfs/src/github/python-language/docs/api.rst:document isn't included in any toctree
|
parthea
force-pushed
the
delete-owlbot-py
branch
from
November 4, 2021 16:22
dceb2d5
to
dba9bfe
Compare
This is ready for review. |
@busunkim96 Please could you review/approve? |
busunkim96
approved these changes
Nov 9, 2021
Ah sorry, I don't think this made it through my normal filter. Could you please "re-request" a review if I've looked at a PR previously? Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
api: language
Issues related to the googleapis/python-language API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that googleapis/synthtool#1244 is merged, owlbot.py is no longer required in this repo. We can add owlbot.py back in the future if repository specific customizations are needed.