-
Notifications
You must be signed in to change notification settings - Fork 9
samples: enable pubsub notifications #13
samples: enable pubsub notifications #13
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
Please disregard since this seems to be a bug from snippet-bot. I opened an issue here googleapis/repo-automation-bots#2325 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TrucHLe!
I'm leaving comments on this one as it looks to be your oldest PR, but most of the comments apply to all samples.
To make sure CI runs your samples, please make the following changes:
-
Inside client libraries, the samples are expected to be in subdirectories of
samples
. See here for more information. -
Each sample directory should have a
requirements.txt
andrequirements-test.txt
files. See here.
I believe this will work for your samples:
requirements.txt
google-cloud-contact-center-insights==0.2.0
requirements-test.txt
pytest==6.2.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the PR :)
Some of the checks failed because they couldn't find a |
Hey @TrucHLe, Sorry about that, I made a change to the You should now also be able to run the tests and lint through nox. Detailed instructions are here. |
Hey @busunkim96, Thanks for the tip! I don't think I have the permission to add labels to PRs in this repo (the labels settings button doesn't show up in my view). Can you grant me this permission? I want to apply the |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #12 🦕