Skip to content
This repository has been archived by the owner on Jul 6, 2023. It is now read-only.

samples: enable pubsub notifications #13

Merged
merged 24 commits into from
Sep 1, 2021

Conversation

TrucHLe
Copy link
Contributor

@TrucHLe TrucHLe commented Aug 3, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #12 🦕

@TrucHLe TrucHLe requested a review from a team as a code owner August 3, 2021 18:57
@TrucHLe TrucHLe requested a review from crwilcox August 3, 2021 18:57
@product-auto-label product-auto-label bot added the api: contactcenterinsights Issues related to the googleapis/python-contact-center-insights API. label Aug 3, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 3, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 3, 2021
@snippet-bot
Copy link

snippet-bot bot commented Aug 3, 2021

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@TrucHLe
Copy link
Contributor Author

TrucHLe commented Aug 3, 2021

Here is the summary of possible violations 😱

There is a possible violation for not having product prefix.

The end of the violation section. All the stuff below is FYI purposes only.

Here is the summary of changes.

You are about to add 1 region tag.
This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Please disregard since this seems to be a bug from snippet-bot. I opened an issue here googleapis/repo-automation-bots#2325

@TrucHLe TrucHLe changed the title samples: initial update pubsub notifications samples samples: initial enable and disable pubsub notifications samples Aug 4, 2021
@TrucHLe TrucHLe changed the title samples: initial enable and disable pubsub notifications samples samples: enable/disable pubsub notifications Aug 12, 2021
@TrucHLe TrucHLe changed the title samples: enable/disable pubsub notifications samples: enable pubsub notifications Aug 16, 2021
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TrucHLe!

I'm leaving comments on this one as it looks to be your oldest PR, but most of the comments apply to all samples.

To make sure CI runs your samples, please make the following changes:

  1. Inside client libraries, the samples are expected to be in subdirectories of samples. See here for more information.

  2. Each sample directory should have a requirements.txt and requirements-test.txt files. See here.

I believe this will work for your samples:

requirements.txt

google-cloud-contact-center-insights==0.2.0

requirements-test.txt

pytest==6.2.4

samples/tests/test_enable_pubsub_notifications.py Outdated Show resolved Hide resolved
samples/tests/test_enable_pubsub_notifications.py Outdated Show resolved Hide resolved
samples/enable_pubsub_notifications.py Outdated Show resolved Hide resolved
samples/enable_pubsub_notifications.py Outdated Show resolved Hide resolved
samples/enable_pubsub_notifications.py Outdated Show resolved Hide resolved
samples/enable_pubsub_notifications.py Outdated Show resolved Hide resolved
samples/disable_pubsub_notifications.py Outdated Show resolved Hide resolved
Copy link
Contributor Author

@TrucHLe TrucHLe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the PR :)

@TrucHLe
Copy link
Contributor Author

TrucHLe commented Aug 17, 2021

Some of the checks failed because they couldn't find a noxfile.py in python-contact-center-insights/samples/snippets. I'm not sure how I should create this noxfile/which example I should use, any help is appreciated!

@busunkim96 busunkim96 added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 18, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 18, 2021
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 18, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 18, 2021
@busunkim96
Copy link
Contributor

Hey @TrucHLe,

Sorry about that, I made a change to the owlbot.py in #30 to automatically add noxfile.py in the postprocessor script. To add it to other PRs you can add the owlbot:run label (or wait for this one to land first).

You should now also be able to run the tests and lint through nox. Detailed instructions are here.

@TrucHLe
Copy link
Contributor Author

TrucHLe commented Aug 19, 2021

Hey @busunkim96, Thanks for the tip! I don't think I have the permission to add labels to PRs in this repo (the labels settings button doesn't show up in my view). Can you grant me this permission? I want to apply the owlbot:run label to all of my other PRs.

@telpirion telpirion self-requested a review August 27, 2021 16:12
@telpirion telpirion added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 27, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 27, 2021
@TrucHLe TrucHLe requested a review from telpirion August 27, 2021 17:14
@telpirion telpirion merged commit b76dbbc into googleapis:main Sep 1, 2021
@TrucHLe TrucHLe deleted the enable_pubsub_notification branch October 25, 2021 19:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: contactcenterinsights Issues related to the googleapis/python-contact-center-insights API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sample for enabling Pub/Sub notification
4 participants