Skip to content
This repository has been archived by the owner on Jul 6, 2023. It is now read-only.

samples: create conversation, create analysis, export data to BigQuery #11

Closed
wants to merge 37 commits into from

Conversation

TrucHLe
Copy link
Contributor

@TrucHLe TrucHLe commented Aug 3, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #10 🦕
Fixes #16
Fixes #17
Fixes #19

@TrucHLe TrucHLe requested a review from a team as a code owner August 3, 2021 15:24
@TrucHLe TrucHLe requested a review from busunkim96 August 3, 2021 15:24
@product-auto-label product-auto-label bot added api: contactcenterinsights Issues related to the googleapis/python-contact-center-insights API. samples Issues that are directly related to samples. labels Aug 3, 2021
@snippet-bot
Copy link

snippet-bot bot commented Aug 3, 2021

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 3, 2021
samples/create_conversation.py Outdated Show resolved Hide resolved
samples/delete_conversation.py Outdated Show resolved Hide resolved
samples/tests/test_create_conversation.py Outdated Show resolved Hide resolved
@TrucHLe TrucHLe changed the title samples: initial create and delete conversation samples samples: initial create/delete conversation, create/delete analysis samples Aug 6, 2021
@TrucHLe TrucHLe changed the title samples: initial create/delete conversation, create/delete analysis samples samples: create/delete conversation, create/delete analysis Aug 6, 2021
@TrucHLe TrucHLe changed the title samples: create/delete conversation, create/delete analysis samples: create/delete conversation, create/delete analysis, export data to BigQuery Aug 9, 2021
Copy link

@tmatsuo tmatsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments explaining why snippet-bot still thinks there're some problems.

samples/delete_analysis.py Outdated Show resolved Hide resolved
samples/delete_conversation.py Outdated Show resolved Hide resolved
samples/delete_conversation.py Outdated Show resolved Hide resolved
Copy link

@tmatsuo tmatsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also get approval from @busunkim96 ?

@TrucHLe TrucHLe changed the title samples: create/delete conversation, create/delete analysis, export data to BigQuery samples: createconversation, createanalysis, export data to BigQuery Aug 16, 2021
@TrucHLe TrucHLe changed the title samples: createconversation, createanalysis, export data to BigQuery samples: create conversation, create analysis, export data to BigQuery Aug 16, 2021
@TrucHLe
Copy link
Contributor Author

TrucHLe commented Aug 18, 2021

FYI the export code sample has a try catch loop to catch an LRO error. However this error shouldn't be thrown. I filed an issue here googleapis/python-api-core#257.

@busunkim96 busunkim96 added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 20, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 20, 2021
@TrucHLe TrucHLe closed this Sep 7, 2021
@TrucHLe TrucHLe deleted the create_del_convo branch October 25, 2021 19:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: contactcenterinsights Issues related to the googleapis/python-contact-center-insights API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
3 participants