fix: improve backup name regex when listing backups #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the regular expression to match the format specified in the Bigtable Admin API documentation: https://cloud.google.com/bigtable/docs/reference/admin/rest/v2/projects.instances.clusters.backups/create
product-auto-label
bot
added
size: xs
igorbernstein2
approved these changes
May 29, 2024
There was a problem hiding this comment.
Thanks for the fix!
I dont really think we should be doing these kind of validations on the client to begin with.
I think I would prefer for the regex to just be something like: backups/(?P<backup_id>[^/]+) and just have the server do all of the validation.
This PR is an improvement so I'm ok merging it as is. However in the future we really should stop duplicating server logic here.
daniel-sanche
added
the
kokoro:run
daniel-sanche
changed the title
yoshi-kokoro
removed
the
kokoro:run
daniel-sanche
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the regular expression to match the format specified in the Bigtable Admin API documentation: https://cloud.google.com/bigtable/docs/reference/admin/rest/v2/projects.instances.clusters.backups/create
Fixes #969