Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update api_core submodule #897

Merged
merged 18 commits into from
Dec 15, 2023
Merged

chore: update api_core submodule #897

merged 18 commits into from
Dec 15, 2023

Conversation

daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Dec 11, 2023 •
edited
Loading

This PR updates the api_core dependency to make use of some of the features added upstream:

  • we can get rid of the expensive _convert_retry_deadline wrapper, which caught and converted error types. Instead, we can use the api_core exception_factory functionality, to build an exception at raise-time
  • we can make use of retry_target_async instead of the higher-level AsyncRetry objects, which saves us some overhead
  • We can get rid of a workaround fix for a race-condition present in the old async_retry implementation
  • also, pulled in the native namespaces changes that were applied to main, because recent versions of dependencies are now expecting it

Fixes #858

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigtable Issues related to the googleapis/python-bigtable API. labels Dec 11, 2023
@daniel-sanche daniel-sanche mentioned this pull request Dec 12, 2023
Merged
@daniel-sanche daniel-sanche changed the title [DRAFT] chore: update api_core submodule chore: update api_core submodule Dec 13, 2023
@daniel-sanche daniel-sanche marked this pull request as ready for review December 13, 2023 21:54
@daniel-sanche daniel-sanche requested review from a team as code owners December 13, 2023 21:54
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2023
@daniel-sanche daniel-sanche mentioned this pull request Dec 15, 2023
Merged
@daniel-sanche daniel-sanche merged commit 9342e27 into googleapis:experimental_v3 Dec 15, 2023
8 of 10 checks passed
daniel-sanche added a commit that referenced this pull request Feb 5, 2024
@daniel-sanche @gcf-owl-bot
chore: add experimental async data client (#920)
7088e39 
* feat: add new v3.0.0 API skeleton (#745)

* feat: improve rows filters (#751)

* feat: read rows query model class (#752)

* feat: implement row and cell model classes (#753)

* feat: add pooled grpc transport (#748)

* feat: implement read_rows (#762)

* feat: implement mutate rows (#769)

* feat: literal value filter (#767)

* feat: row_exists and read_row (#778)

* feat: read_modify_write and check_and_mutate_row (#780)

* feat: sharded read rows (#766)

* feat: ping and warm with metadata (#810)

* feat: mutate rows batching (#770)

* chore: restructure module paths (#816)

* feat: improve timeout structure (#819)

* fix: api errors apply to all bulk mutations

* chore: reduce public api surface (#820)

* feat: improve error group tracebacks on < py11 (#825)

* feat: optimize read_rows (#852)

* chore: add user agent suffix (#842)

* feat: optimize retries (#854)

* feat: add test proxy (#836)

* chore(tests): add conformance tests to CI for v3 (#870)

* chore(tests): turn off fast fail for conformance tets (#882)

* feat: add TABLE_DEFAULTS enum for table method arguments (#880)

* fix: pass None for retry in gapic calls (#881)

* feat: replace internal dictionaries with protos in gapic calls (#875)

* chore: optimize gapic calls (#863)

* feat: expose retryable error codes to users (#879)

* chore: update api_core submodule (#897)

* chore: merge main into experimental_v3 (#900)

* chore: pin conformance tests to v0.0.2 (#903)

* fix: bulk mutation eventual success (#909)

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daniel-sanche @igorbernstein2 @yoshi-kokoro