Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Increase the maximum retention period for a Cloud Bigtable backup from 30 days to 90 days #817

Merged
merged 4 commits into from
Jul 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion google/cloud/bigtable_admin_v2/types/table.py
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,7 @@ class Backup(proto.Message):
expire_time (google.protobuf.timestamp_pb2.Timestamp):
Required. The expiration time of the backup, with
microseconds granularity that must be at least 6 hours and
at most 30 days from the time the request is received. Once
at most 90 days from the time the request is received. Once
the ``expire_time`` has passed, Cloud Bigtable will delete
the backup and free the resources used by the backup.
start_time (google.protobuf.timestamp_pb2.Timestamp):
Expand Down
12 changes: 12 additions & 0 deletions google/cloud/bigtable_v2/types/bigtable.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,14 @@ class ReadRowsRequest(proto.Message):
request_stats_view (google.cloud.bigtable_v2.types.ReadRowsRequest.RequestStatsView):
The view into RequestStats, as described
above.
reversed_ (bool):
Experimental API - Please note that this API is currently
experimental and can change in the future.

Return rows in lexiographical descending order of the row
keys. The row contents will not be affected by this flag.
Example result set: [ {key: "k2", "f:col1": "v1", "f:col2":
"v1"}, {key: "k1", "f:col1": "v2", "f:col2": "v2"} ].
"""

class RequestStatsView(proto.Enum):
Expand Down Expand Up @@ -131,6 +139,10 @@ class RequestStatsView(proto.Enum):
number=6,
enum=RequestStatsView,
)
reversed_: bool = proto.Field(
proto.BOOL,
number=7,
)


class ReadRowsResponse(proto.Message):
Expand Down
9 changes: 9 additions & 0 deletions google/cloud/bigtable_v2/types/feature_flags.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,21 @@ class FeatureFlags(proto.Message):
endusers directly.

Attributes:
reverse_scans (bool):
Notify the server that the client supports
reverse scans. The server will reject
ReadRowsRequests with the reverse bit set when
this is absent.
mutate_rows_rate_limit (bool):
Notify the server that the client enables
batch write flow control by requesting
RateLimitInfo from MutateRowsResponse.
"""

reverse_scans: bool = proto.Field(
proto.BOOL,
number=1,
)
mutate_rows_rate_limit: bool = proto.Field(
proto.BOOL,
number=3,
Expand Down
2 changes: 1 addition & 1 deletion scripts/fixup_bigtable_v2_keywords.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class bigtableCallTransformer(cst.CSTTransformer):
'ping_and_warm': ('name', 'app_profile_id', ),
'read_change_stream': ('table_name', 'app_profile_id', 'partition', 'start_time', 'continuation_tokens', 'end_time', 'heartbeat_duration', ),
'read_modify_write_row': ('table_name', 'row_key', 'rules', 'app_profile_id', ),
'read_rows': ('table_name', 'app_profile_id', 'rows', 'filter', 'rows_limit', 'request_stats_view', ),
'read_rows': ('table_name', 'app_profile_id', 'rows', 'filter', 'rows_limit', 'request_stats_view', 'reversed_', ),
'sample_row_keys': ('table_name', 'app_profile_id', ),
}

Expand Down