Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: optimize row merging #628

Merged
merged 25 commits into from
Aug 17, 2022
Merged

perf: optimize row merging #628

merged 25 commits into from
Aug 17, 2022

Commits on Aug 5, 2022

  1. test: improve the row merging tests 

    - extract read-rows-acceptance-test.json based tests into own file
- update the json to match the latest available in https://github.com/googleapis/conformance-tests/tree/main/bigtable/v2
- use parameterized pytest test to run all of the scenarios (instead of creating a function for each json blob)
- use json protobufs to parse the file

I left a TODO to allow easy updates of the file, unfortunately its not straight forward as the canonical protos get renamed for python gapic
Next PR will extract row merging functionality from row_data to make it easier to maintain
    @igorbernstein2
    igorbernstein2 committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    e3bd84c View commit details
    Browse the repository at this point in the history

  2. fix type annotation

    @igorbernstein2
    igorbernstein2 committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    32c0551 View commit details
    Browse the repository at this point in the history

  3. fix lints

    @igorbernstein2
    igorbernstein2 committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    0dcdec4 View commit details
    Browse the repository at this point in the history

  4. fix coverage

    @igorbernstein2
    igorbernstein2 committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    a6345e0 View commit details
    Browse the repository at this point in the history

  5. fix pytest warning

    @igorbernstein2
    igorbernstein2 committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    36e29ca View commit details
    Browse the repository at this point in the history

  6. wip - new row merger

    @igorbernstein2
    igorbernstein2 committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    5c89bc7 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2022

  1. wip: split into methods

    @igorbernstein2
    igorbernstein2 committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    b33f5ad View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into row_merger

    @igorbernstein2
    igorbernstein2 committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    894d3da View commit details
    Browse the repository at this point in the history

  3. format

    @igorbernstein2
    igorbernstein2 committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    6465a9d View commit details
    Browse the repository at this point in the history

  4. tweaks

    @igorbernstein2
    igorbernstein2 committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    6b70004 View commit details
    Browse the repository at this point in the history

  5. lint

    @igorbernstein2
    igorbernstein2 committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    1fd7e46 View commit details
    Browse the repository at this point in the history

  6. fixes

    @igorbernstein2
    igorbernstein2 committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    01f4680 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2022

  1. improve coverage

    @igorbernstein2
    igorbernstein2 committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    a93efbc View commit details
    Browse the repository at this point in the history

  2. lint

    @igorbernstein2
    igorbernstein2 committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    a848082 View commit details
    Browse the repository at this point in the history

  3. typo

    @igorbernstein2
    igorbernstein2 committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    60f7fee View commit details
    Browse the repository at this point in the history

  4. comment

    @igorbernstein2
    igorbernstein2 committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    1ca5745 View commit details
    Browse the repository at this point in the history

  5. coverage

    @igorbernstein2
    igorbernstein2 committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    b73ec7d View commit details
    Browse the repository at this point in the history

  6. coverage

    @igorbernstein2
    igorbernstein2 committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    71f4513 View commit details
    Browse the repository at this point in the history

  7. lint

    @igorbernstein2
    igorbernstein2 committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    62a6c19 View commit details
    Browse the repository at this point in the history

  8. remove unecssary check

    @igorbernstein2
    igorbernstein2 committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    2ca3e62 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. Merge remote-tracking branch 'origin/main' into row_merger 

    # Conflicts:
#	google/cloud/bigtable/row_data.py
    @igorbernstein2
    igorbernstein2 committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    9db0027 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'igor/row_merger' into row_merger 

    # Conflicts:
#	google/cloud/bigtable/row_merger.py
    @igorbernstein2
    igorbernstein2 committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    ef8cf3f View commit details
    Browse the repository at this point in the history

  3. address feedback

    @igorbernstein2
    igorbernstein2 committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    37d1ced View commit details
    Browse the repository at this point in the history

  4. flake8

    @igorbernstein2
    igorbernstein2 committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    9012af1 View commit details
    Browse the repository at this point in the history

  5. revert accidental commit

    @igorbernstein2
    igorbernstein2 committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    2b28101 View commit details
    Browse the repository at this point in the history