Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): require protobuf<4.0.0 on v1 branch #602

Merged
merged 3 commits into from
Jun 7, 2022
Merged

fix(deps): require protobuf<4.0.0 on v1 branch #602

merged 3 commits into from
Jun 7, 2022

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jun 7, 2022

No description provided.

@parthea parthea requested review from a team as code owners June 7, 2022 14:37
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/python-bigtable API. labels Jun 7, 2022
@Mariatta
Copy link
Contributor

Mariatta commented Jun 7, 2022

The docs build is failing because of a recent release of Sphinx v 5.
I made a separate PR to address just the docs build: https://github.com/googleapis/python-bigtable/pull/603/files

@Mariatta
Copy link
Contributor

Mariatta commented Jun 7, 2022

We can also alternatively pin it to Sphinx <5 but I think keeping it up to date and recent would be better.

@parthea parthea merged commit e044328 into v1 Jun 7, 2022
@parthea parthea deleted the pin-protobuf-v1 branch June 7, 2022 23:12
@release-please release-please bot mentioned this pull request Jun 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parthea @Mariatta