Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use single routing metadata header #1005

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Conversation

daniel-sanche
Copy link
Contributor

Fixes #1004, and adds a unit test to ensure only a single routing header is sent

A longer term fix is proposed in the gapic generator at googleapis/gapic-generator-python#2079, but this patch will work until the upstream is updated

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/python-bigtable API. labels Jul 27, 2024
@daniel-sanche daniel-sanche added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 27, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 27, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jul 27, 2024
@daniel-sanche daniel-sanche added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 29, 2024
@daniel-sanche daniel-sanche marked this pull request as ready for review July 29, 2024 19:12
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 29, 2024
@daniel-sanche daniel-sanche requested review from a team as code owners July 29, 2024 19:12
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 29, 2024
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 30, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 30, 2024
@daniel-sanche daniel-sanche merged commit 20eeb0a into main Jul 30, 2024
25 of 32 checks passed
@daniel-sanche daniel-sanche deleted the single_routing_metadata branch July 30, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate x-goog-request-params routing header
4 participants