-
Notifications
You must be signed in to change notification settings - Fork 58
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Ensure message fields are copied when building retry request (#533)
* fix: Ensure message fields are copied when building retry request Use the to_dict() function when building the ReadRowsRequest arguments. This way, all available fields in the message will get copied over. The `message.filter` field needed a special handling, since the to_dict() function doesn't seem to parse the value the way we want it to be. Fixes internal bug #214449800 * Use copy_from instead of to_dict. copy_from doesn't copy over "empty" fields, so had to adjust the test case expected values. * Use the copy_from function from proto.Message * Bump the min version of proto-plus * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
- Loading branch information
1 parent
c1265ba
commit ff7f190
Showing
4 changed files
with
11 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters