Skip to content

Commit

Permalink
feat: Adding feature flags for routing cookie and retry info (#905)
Browse files Browse the repository at this point in the history
* feat: Modify ModifyColumnFamiliesRequest proto to expose ignore_warnings field

PiperOrigin-RevId: 590940407

Source-Link: googleapis/googleapis@fb027c8

Source-Link: googleapis/googleapis-gen@f0728cd
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjA3MjhjZGEyMjdiMzg4MzU4MjJjNGU1NTE5ZTU2OGNlOGQyYjVhYyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat: Adding feature flags for routing cookie and retry info

PiperOrigin-RevId: 591912877

Source-Link: googleapis/googleapis@f6505fe

Source-Link: googleapis/googleapis-gen@7499187
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzQ5OTE4NzQxNWY4ZDQwNWVmMGQ0NmRkNmZmNjA4YjEyNWM1M2M4ZiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
  • Loading branch information
gcf-owl-bot[bot] and gcf-owl-bot[bot] authored Jan 11, 2024
1 parent 9022f54 commit 1859e67
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 1 deletion.
7 changes: 7 additions & 0 deletions google/cloud/bigtable_admin_v2/types/bigtable_table_admin.py
Original file line number Diff line number Diff line change
Expand Up @@ -597,6 +597,9 @@ class ModifyColumnFamiliesRequest(proto.Message):
earlier modifications can be masked by later
ones (in the case of repeated updates to the
same family, for example).
ignore_warnings (bool):
Optional. If true, ignore safety checks when
modifying the column families.
"""

class Modification(proto.Message):
Expand Down Expand Up @@ -662,6 +665,10 @@ class Modification(proto.Message):
number=2,
message=Modification,
)
ignore_warnings: bool = proto.Field(
proto.BOOL,
number=3,
)


class GenerateConsistencyTokenRequest(proto.Message):
Expand Down
16 changes: 16 additions & 0 deletions google/cloud/bigtable_v2/types/feature_flags.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,14 @@ class FeatureFlags(proto.Message):
Notify the server that the client supports the
last_scanned_row field in ReadRowsResponse for long-running
scans.
routing_cookie (bool):
Notify the server that the client supports
using encoded routing cookie strings to retry
requests with.
retry_info (bool):
Notify the server that the client supports
using retry info back off durations to retry
requests with.
"""

reverse_scans: bool = proto.Field(
Expand All @@ -77,6 +85,14 @@ class FeatureFlags(proto.Message):
proto.BOOL,
number=4,
)
routing_cookie: bool = proto.Field(
proto.BOOL,
number=6,
)
retry_info: bool = proto.Field(
proto.BOOL,
number=7,
)


__all__ = tuple(sorted(__protobuf__.manifest))
2 changes: 1 addition & 1 deletion scripts/fixup_bigtable_admin_v2_keywords.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ class bigtable_adminCallTransformer(cst.CSTTransformer):
'list_instances': ('parent', 'page_token', ),
'list_snapshots': ('parent', 'page_size', 'page_token', ),
'list_tables': ('parent', 'view', 'page_size', 'page_token', ),
'modify_column_families': ('name', 'modifications', ),
'modify_column_families': ('name', 'modifications', 'ignore_warnings', ),
'partial_update_cluster': ('cluster', 'update_mask', ),
'partial_update_instance': ('instance', 'update_mask', ),
'restore_table': ('parent', 'table_id', 'backup', ),
Expand Down

0 comments on commit 1859e67

Please sign in to comment.