Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NullIndex in ML model.predict error #917

Merged
merged 1 commit into from
Aug 27, 2024
Merged

fix: NullIndex in ML model.predict error #917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bigframes/ml/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@ def _apply_ml_tvf(

result_sql = apply_sql_tvf(input_sql)
df = self._session.read_gbq(result_sql, index_col=index_col_ids)
df.index.names = index_labels
if df._has_index:
df.index.names = index_labels
# Restore column labels
df.rename(
columns={
Expand Down
10 changes: 9 additions & 1 deletion tests/system/large/ml/test_linear_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def test_linear_regression_customized_params_fit_score(
assert reloaded_model.learning_rate == 0.2


def test_unordered_mode_regression_configure_fit_score(
def test_unordered_mode_linear_regression_configure_fit_score_predict(
unordered_session, penguins_table_id, dataset_id
):
model = bigframes.ml.linear_model.LinearRegression()
Expand Down Expand Up @@ -154,6 +154,14 @@ def test_unordered_mode_regression_configure_fit_score(
assert reloaded_model.max_iterations == 20
assert reloaded_model.tol == 0.01

pred = reloaded_model.predict(df)
utils.check_pandas_df_schema_and_index(
pred,
columns=("predicted_body_mass_g",),
col_exact=False,
index=334,
)


# TODO(garrettwu): add tests for param warm_start. Requires a trained model.

Expand Down