Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update toc entry to properly include summary pages #415

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

dandhlee
Copy link
Contributor

@dandhlee dandhlee commented Mar 5, 2024

When the files aren't present, docfx does not convert the files from .yml extension to .html. I've tested this locally to ensure docfx keeps the file extension to .html as needed, which we'll need for the new files added for summary pages.

The only entry that should change in the future would be summary_overview.html to summary_overview.md. Filed #414 to keep track of that.

🦕

@dandhlee dandhlee requested review from a team as code owners March 5, 2024 23:28
@dandhlee dandhlee requested a review from stevewalker-de March 5, 2024 23:28
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 5, 2024
@dandhlee dandhlee requested review from ashleyxuu and removed request for stevewalker-de March 5, 2024 23:29
@dandhlee dandhlee changed the title chore: Update toc.yml chore: update toc entry to properly include summary pages Mar 5, 2024
@dandhlee dandhlee added the automerge Merge the pull request once unit tests and other checks pass. label Mar 5, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1dd0f3e into main Mar 6, 2024
14 of 15 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the dandhlee-patch-1 branch March 6, 2024 00:20
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants