Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add requests dependency to the anthropic remote function #1137

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Nov 7, 2024

The latest anthropic release broke the notebook tests. More details in anthropics/anthropic-sdk-python#738.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 377738242 🦕

The latest anthropic release broke the notebook tests. More details in
anthropics/anthropic-sdk-python#738.
@shobsi shobsi requested review from a team as code owners November 7, 2024 00:05
@shobsi shobsi requested a review from jialuoo November 7, 2024 00:05
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 7, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Nov 7, 2024
@shobsi shobsi requested a review from GarrettWu November 7, 2024 01:24
@shobsi shobsi merged commit 0dea941 into main Nov 7, 2024
23 checks passed
@shobsi shobsi deleted the shobs-fix-anthropic-notebook branch November 7, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants