-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure exception is available when BackgroundConsumer open stream fails #357
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
1a64fff
fix: ensure exception is available when BackgroundConsumer open strea…
parthea 97c2363
chore: fix coverage
parthea 2b24714
Merge branch 'main' into fix-background-consumer-start-eats-exception
parthea 947b657
Merge branch 'main' into fix-background-consumer-start-eats-exception
parthea ad1f29f
Merge branch 'main' into fix-background-consumer-start-eats-exception
rosiezou 7ec7832
Merge branch 'main' into fix-background-consumer-start-eats-exception
parthea c7f63bd
Address review comments
parthea 3304ef1
revert
parthea e120a0c
address review feedback
parthea 753a591
raise grpc.RpcError instead of GoogleAPICallError
parthea 3c1daa9
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 9423063
Merge branch 'main' into fix-background-consumer-start-eats-exception
parthea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In examining this file, it seems to me that
_RequestQueueGenerator._is_active
(lines 91 et seq) should bedef
d asreturn self.call is not None and self.call.is_active()
. The way it's currently written it will returnTrue
whenself.call == None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in e120a0c