Skip to content

Commit

Permalink
docs: Update SDK Job Submission with Ray v2.33 updated comments
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 672234200
  • Loading branch information
speedstorm1 authored and copybara-github committed Sep 8, 2024
1 parent 6d1f7fd commit 7fda11f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
7 changes: 4 additions & 3 deletions google/cloud/aiplatform/vertex_ray/dashboard_sdk.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# -*- coding: utf-8 -*-

# Copyright 2022 Google LLC
# Copyright 2024 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand All @@ -17,9 +17,10 @@

"""Utility to interact with Ray-on-Vertex dashboard."""

from ray.dashboard.modules import dashboard_sdk as oss_dashboard_sdk

from .util import _gapic_utils
from .util import _validation_utils
from ray.dashboard.modules import dashboard_sdk as oss_dashboard_sdk


def get_job_submission_client_cluster_info(
Expand All @@ -28,7 +29,7 @@ def get_job_submission_client_cluster_info(
"""A vertex_ray implementation of get_job_submission_client_cluster_info().
Implements
https://github.com/ray-project/ray/blob/ray-2.3.1/dashboard/modules/dashboard_sdk.py#L82
https://github.com/ray-project/ray/blob/ray-2.33.0/python/ray/dashboard/modules/dashboard_sdk.py#L84
This will be called in from Ray Job API Python client.
Args:
Expand Down
2 changes: 1 addition & 1 deletion samples/model-builder/upload_model_sample.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@
# See the License for the specific language governing permissions and
# limitations under the License.

# [START aiplatform_sdk_upload_model_sample]
from typing import Dict, Optional, Sequence

from google.cloud import aiplatform
from google.cloud.aiplatform import explain


# [START aiplatform_sdk_upload_model_sample]
def upload_model_sample(
project: str,
location: str,
Expand Down

0 comments on commit 7fda11f

Please sign in to comment.