Skip to content

Commit

Permalink
fix: Remove redundant progress bar update commands within runnable in…
Browse files Browse the repository at this point in the history
…ference

PiperOrigin-RevId: 700151822
  • Loading branch information
vertex-sdk-bot authored and copybara-github committed Nov 26, 2024
1 parent d7dff72 commit 598c931
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions vertexai/preview/evaluation/_evaluation.py
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,6 @@ def _run_runnable_inference(
tasks.append(task)
for task in tasks:
response_dict, latency, failure = task.result()
pbar.update(1)
responses.append(response_dict["output"])
latency_list.append(latency)
failure_list.append(failure)
Expand Down Expand Up @@ -602,7 +601,6 @@ def _run_runnable_inference(
"the pre-existing `response` column provided "
"in the evaluation dataset is not used."
)
pbar.update(1)
elif callable(runnable):
with tqdm(total=len(evaluation_run_config.dataset)) as pbar:
with futures.ThreadPoolExecutor(
Expand Down Expand Up @@ -645,7 +643,6 @@ def _run_runnable_inference(
" column provided in the evaluation dataset"
" is not used."
)
pbar.update(1)
else:
raise ValueError(f"Unsupported runnable type: {type(runnable)}")

Expand Down

0 comments on commit 598c931

Please sign in to comment.