This repository has been archived by the owner on Jan 26, 2018. It is now read-only.
Loosen oauth2client lower bound for Python #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 91.23% (diff: 100%)@@ master #140 diff @@
==========================================
Files 3 3
Lines 719 719
Methods 150 150
Messages 0 0
Branches 116 116
==========================================
Hits 656 656
Misses 63 63
Partials 0 0
|
dhermes
reviewed
Sep 29, 2016
| @@ -18,7 +18,7 @@ | |||
|
|
|||
| auth: | |||
| python: | |||
| version: '3.0.0' | |||
| version: '1.4.11' | |||
There was a problem hiding this comment.
You might need to start at 2.0. There was a large breakage there, but if your code doesn't depend on it that isn't such a big deal.
|
@dhermes Done. |
|
@bjwatson SG. |
|
What was the context behind this change? I see that |
|
@geigerj We're only on 3.0.0 because |
geigerj
approved these changes
Sep 29, 2016
|
@geigerj See @jonparrott's comment for more context. |
|
@geigerj I just pushed a version bump that I used this morning. I'm going to assume it's okay and merge, rather than waste your time with extra reviews. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @jonparrott and @dhermes