Skip to content
This repository has been archived by the owner on Jan 18, 2025. It is now read-only.

PEP8 cleanup #540

Merged
merged 8 commits into from
Jul 11, 2016
Merged

Conversation

pferate
Copy link
Contributor

@pferate pferate commented Jul 8, 2016

Resolved numerous PEP8 issues, found with flake8.

pferate added 5 commits July 7, 2016 13:55
Fixed flake8 F841 errors: local variable is assigned to but never used.
Move messages split up by multiple print calls to multi-line strings.
@theacodes
Copy link
Contributor

Want to go ahead and add a flake8 tox env?

print()
print(' --noauth_local_webserver')
print()
print(_BROWSER_OPENED_MESSAGE % authorize_url)

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@pferate
Copy link
Contributor Author

pferate commented Jul 8, 2016

Added a flake8 tox environment, using the plug-in flake8-putty for some added flexibility.

@dhermes
Copy link
Contributor

dhermes commented Jul 8, 2016

This is awesome!

@@ -64,7 +64,7 @@ def __init__(self, email=None, *args, **kwargs):
email: an email that specifies the service account to use.
Only necessary if using custom service accounts
(see https://cloud.google.com/compute/docs/access/create-enable-service-accounts-for-instances#createdefaultserviceaccount).
"""
""" # noqa: E501

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@theacodes
Copy link
Contributor

This looks fantastic, can you add --import-order-style google? I think that'll be the last big thing. :)

@@ -162,7 +162,7 @@ def test_callback(sender, request, credentials, **kwargs):

oauth2_authorized.connect(test_callback)

"""
""" # noqa: E501

This comment was marked as spam.

This comment was marked as spam.

@nathanielmanistaatgoogle
Copy link
Contributor

I agree; delightful improvement.

@pferate
Copy link
Contributor Author

pferate commented Jul 9, 2016

@jonparrott: --import-order-style google came up with over 200 errors! I'll start looking into that on Monday or Tuesday.

@nathanielmanistaatgoogle
Copy link
Contributor

Change content looks good.

I'd prefer for the eighth and tenth commits to be folded into the sixth rather than exist on their own; how strong are your git skills?

@pferate
Copy link
Contributor Author

pferate commented Jul 10, 2016

I can do that, but @jonparrott has been using merge --squash, so they would be folded into one commit when they get merged, so that's why I didn't do that here.

@nathanielmanistaatgoogle
Copy link
Contributor

Sure, but doesn't that one commit get a list of what happened generated from the line of commits before the squash?

@pferate
Copy link
Contributor Author

pferate commented Jul 11, 2016

Added check for import order style and fixed existing issues. Will squash my other commits tomorrow.

@pferate
Copy link
Contributor Author

pferate commented Jul 11, 2016

Commits have been squashed.

@theacodes
Copy link
Contributor

Sure, but doesn't that one commit get a list of what happened generated from the line of commits before the squash?

We can customize the commit message when we merge. :)

@theacodes
Copy link
Contributor

This LGTM, @nathanielmanistaatgoogle I'll leave it up to you to merge.

@nathanielmanistaatgoogle nathanielmanistaatgoogle merged commit ac4385c into googleapis:master Jul 11, 2016
@theacodes
Copy link
Contributor

Thanks so much for this, @pferate!

@pferate
Copy link
Contributor Author

pferate commented Jul 11, 2016

Glad I could help!

@theacodes theacodes mentioned this pull request Jul 28, 2016
@pferate pferate deleted the pep8_cleanup branch July 29, 2016 22:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants