-
Notifications
You must be signed in to change notification settings - Fork 430
PEP8 cleanup #540
PEP8 cleanup #540
Conversation
Fixed flake8 F841 errors: local variable is assigned to but never used.
Move messages split up by multiple print calls to multi-line strings.
Want to go ahead and add a flake8 tox env? |
print() | ||
print(' --noauth_local_webserver') | ||
print() | ||
print(_BROWSER_OPENED_MESSAGE % authorize_url) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Added a |
This is awesome! |
@@ -64,7 +64,7 @@ def __init__(self, email=None, *args, **kwargs): | |||
email: an email that specifies the service account to use. | |||
Only necessary if using custom service accounts | |||
(see https://cloud.google.com/compute/docs/access/create-enable-service-accounts-for-instances#createdefaultserviceaccount). | |||
""" | |||
""" # noqa: E501 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This looks fantastic, can you add |
@@ -162,7 +162,7 @@ def test_callback(sender, request, credentials, **kwargs): | |||
|
|||
oauth2_authorized.connect(test_callback) | |||
|
|||
""" | |||
""" # noqa: E501 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
I agree; delightful improvement. |
@jonparrott: |
I can do that, but @jonparrott has been using |
Sure, but doesn't that one commit get a list of what happened generated from the line of commits before the squash? |
Added check for import order style and fixed existing issues. Will squash my other commits tomorrow. |
Commits have been squashed. |
We can customize the commit message when we merge. :) |
This LGTM, @nathanielmanistaatgoogle I'll leave it up to you to merge. |
Thanks so much for this, @pferate! |
Glad I could help! |
Resolved numerous PEP8 issues, found with
flake8
.