Use context manager for assertRaises #537
Conversation
| @@ -25,7 +25,7 @@ | |||
|
|
|||
| from oauth2client import util | |||
| from oauth2client.client import OAuth2Credentials | |||
| from oauth2client.contrib import locked_file | |||
| from oauth2client.contrib.locked_file import CredentialsFileSymbolicLinkError | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -53,4 +53,4 @@ def test_token_info(self): | |||
|
|
|||
|
|
|||
| if __name__ == '__main__': | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Resolve issue googleapis#536.
Using unittest2 for extended unit test capabilities in python 2.6.
Don't need the `if __name__ == '__main__':` clauses in the test files.
|
@pferate this is almost ready, only one outstanding comment (about the |
|
@jonparrott Is there something I missed? I took care of the I only left those checks in the Edit: nevermind, I see that the one you referenced was the one in the |
|
Oh, I see, my apologies. @nathanielmanistaatgoogle I'm merging this tests-only change. Let me know if you have any post-merge concerns. @pferate thanks for doing this! Much appreciated! |
|
No problem @jonparrott! |
Using context manager for assertRaises calls. Also needed to update files using
unittesttounittest2to be able to use context managers in Python 2.6 (was added tounittestin 2.7). Keeping the same import and usage syntax as the other files usingunittest2.