-
Notifications
You must be signed in to change notification settings - Fork 432
Conversation
first question: did you sign the CLA? http://google.github.io/oauth2client/contributing.html (adding a note to README now) |
Done, and submitted to the designated address. |
awesome @fthiery -- i'll take a look in the next few days. thanks! |
overall, this looks good -- but as a first step, could you add some docs? i'm thinking two things: 1/ a simple example of how to use this in the 2/ update the docstrings of any functions you're tweaking. |
Hello Craig, I have been very busy lately, sorry. 2014-05-13 11:08 GMT+02:00 Craig Citro notifications@github.com:
|
hi @fthiery and @sde-melo -- i realized that it might make more sense for me to play with merging. i've gone ahead and merged with master, and then made a few more tweaks on top of that. the branch is here: if one of you could take a quick look (there's just one merge and one more patch on top of this code), and it looks good, I'll go ahead and merge that into master (which will then pick up all these changes). thanks! |
Hello @craigcitro, I was on leave last week, sorry. |
OK, all merged -- thanks so much for the PR! |
Backward compatibility update (Google/oauth2client)
Hello,
We have implemented OAuth 2 for devices.
step1_get_device_and_user_codes allows to retrieve the information to display to the user: verification URL and code. Then the step2_exchange method can be called without arguments to get the credentials.