OAuth 2 for devices implementation

[sde-melo]

Hello,

We have implemented OAuth 2 for devices.
step1_get_device_and_user_codes allows to retrieve the information to display to the user: verification URL and code. Then the step2_exchange method can be called without arguments to get the credentials.

[craigcitro]

first question: did you sign the CLA?

http://google.github.io/oauth2client/contributing.html

(adding a note to README now)

[fthiery]

Done, and submitted to the designated address.

[craigcitro]

awesome @fthiery -- i'll take a look in the next few days.

thanks!

[craigcitro]

overall, this looks good -- but as a first step, could you add some docs? i'm thinking two things:

1/ a simple example of how to use this in the samples/ directory; it could point to the existing documentation online for any explanation. (I mostly want to confirm that I understand how it's supposed to work.)

2/ update the docstrings of any functions you're tweaking.

[sde-melo]

Hello Craig,

I have been very busy lately, sorry.
I have made the changes you requested. Please let me know if it is OK now.

2014-05-13 11:08 GMT+02:00 Craig Citro notifications@github.com:

overall, this looks good -- but as a first step, could you add some docs?
i'm thinking two things:

1/ a simple example of how to use this in the samples/ directory; it
could point to the existing documentation online
https://developers.google.com/accounts/docs/OAuth2ForDevices for any
explanation. (I mostly want to confirm that I understand how it's
supposed to work.)

2/ update the docstrings of any functions you're tweaking.

—
Reply to this email directly or view it on GitHub
#3 (comment).

[craigcitro]

hi @fthiery and @sde-melo -- i went to look at the code, but apparently github can't load the whole changeset at once because it's too large. ;)

this reminded me that i haven't updated the docs in a while; i've done that and pushed. can you sync to HEAD and just re-push the change?

thanks so much!

[craigcitro]

hi @fthiery and @sde-melo -- i realized that it might make more sense for me to play with merging. i've gone ahead and merged with master, and then made a few more tweaks on top of that. the branch is here:
https://github.com/craigcitro/oauth2client/tree/experiment

if one of you could take a quick look (there's just one merge and one more patch on top of this code), and it looks good, I'll go ahead and merge that into master (which will then pick up all these changes).

thanks!

[sde-melo]

Hello @craigcitro,

I was on leave last week, sorry.
I have taken a look and it's OK for us. Thank you for the tweaks!

[craigcitro]

OK, all merged -- thanks so much for the PR!