Skip to content
This repository has been archived by the owner on Nov 5, 2019. It is now read-only.

Adds support for Google Developer Shell session credentials #143

Conversation

aalexand
Copy link
Contributor

No description provided.

@googlebot
Copy link
Collaborator

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

if port == 0:
raise NoDevshellServer()

# pylint:disable=g-import-not-at-top, Delay for performance.

This comment was marked as spam.

This comment was marked as spam.

@skelterjohn
Copy link
Contributor

LGTM. regarding CLA, have you registered as a github googler?

@aalexand
Copy link
Contributor Author

have you registered as a github googler?

I think I have now.

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.76%) to 64.72% when pulling 701abfd on aalexand:support-devshell-credentials into 07da0fe on google:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.76%) to 64.72% when pulling 0627984 on aalexand:support-devshell-credentials into 07da0fe on google:master.

@nathanielmanistaatgoogle
Copy link
Contributor

(I'll be taking a look at this at some point.)

if port == 0:
raise NoDevshellServer()

import socket

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@nathanielmanistaatgoogle
Copy link
Contributor

Please squash your commits.

@aalexand aalexand force-pushed the support-devshell-credentials branch from 1aa4b50 to c8eaffa Compare March 11, 2015 05:27
@coveralls
Copy link

Coverage Status

Coverage increased (+0.73%) to 64.68% when pulling c8eaffa on aalexand:support-devshell-credentials into 07da0fe on google:master.

@nathanielmanistaatgoogle
Copy link
Contributor

I'm satisfied (thank you for the changes). Will anyone else be reviewing this before it goes in?

@skelterjohn
Copy link
Contributor

changes LGTM as well. let me know if you consider this ready to merge.

@nathanielmanistaatgoogle
Copy link
Contributor

I consider this ready to merge.

Last call for obstacles, blockers, and objections?

@aalexand
Copy link
Contributor Author

I think it should be merged now.

nathanielmanistaatgoogle added a commit that referenced this pull request Mar 13, 2015
Adds support for Google Developer Shell session credentials
@nathanielmanistaatgoogle nathanielmanistaatgoogle merged commit d68049b into googleapis:master Mar 13, 2015
@aalexand aalexand deleted the support-devshell-credentials branch March 15, 2015 00:59
@aalexand aalexand restored the support-devshell-credentials branch April 26, 2015 03:26
@aalexand aalexand deleted the support-devshell-credentials branch April 26, 2015 03:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants