-
Notifications
You must be signed in to change notification settings - Fork 432
Adds support for Google Developer Shell session credentials #143
Adds support for Google Developer Shell session credentials #143
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
if port == 0: | ||
raise NoDevshellServer() | ||
|
||
# pylint:disable=g-import-not-at-top, Delay for performance. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
LGTM. regarding CLA, have you registered as a github googler? |
I think I have now. |
CLAs look good, thanks! |
(I'll be taking a look at this at some point.) |
if port == 0: | ||
raise NoDevshellServer() | ||
|
||
import socket |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Please squash your commits. |
1aa4b50
to
c8eaffa
Compare
I'm satisfied (thank you for the changes). Will anyone else be reviewing this before it goes in? |
changes LGTM as well. let me know if you consider this ready to merge. |
I consider this ready to merge. Last call for obstacles, blockers, and objections? |
I think it should be merged now. |
Adds support for Google Developer Shell session credentials
No description provided.