This repository has been archived by the owner on Nov 5, 2019. It is now read-only.
Fall back to using an access_token for revocation. #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -817,7 +817,8 @@ def _revoke(self, http_request): | |||
| http_request: callable, a callable that matches the method signature of | |||
| httplib2.Http.request, used to make the revoke request. | |||
| """ | |||
| self._do_revoke(http_request, self.refresh_token) | |||
| token = self.refresh_token or self.access_token | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -811,13 +811,13 @@ def _do_refresh_request(self, http_request): | |||
| raise AccessTokenRefreshError(error_msg) | |||
|
|
|||
| def _revoke(self, http_request): | |||
| """Revokes the refresh_token and deletes the store if available. | |||
| """Revokes this token and deletes the stored copy (if available). | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
According to the [OAuth2 docs](https://developers.google.com/accounts/docs/OAuth2WebServer#tokenrevoke), we can use either the refresh token or access token when revoking a token. If we've lost the refresh token for some reason, we should fall back to revoking via access token. (Note that if the access token has expired, this will still raise, which is the correct behavior.) Fixes googleapis#132.
craigcitro
added a commit
that referenced
this pull request
Mar 17, 2015
Fall back to using an access_token for revocation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the OAuth2 docs, we can use either the refresh token or access token when revoking a token. If we've lost the refresh token for some reason, we should fall back to revoking via access token. (Note that if the access token has expired, this will still raise, which is the correct behavior.)
Fixes #132.