Skip to content
This repository has been archived by the owner on Jan 18, 2025. It is now read-only.

Conflicts in site-packages/tests #688

Closed
aginiewicz opened this issue Dec 25, 2016 · 2 comments
Closed

Conflicts in site-packages/tests #688

aginiewicz opened this issue Dec 25, 2016 · 2 comments

Comments

@aginiewicz
Copy link

Hello,

I'm maintainer of python{,2}-oauth2client on ArchLinux. Someone reported conflict between oauth2client and two other packages. The conflicts happens due to reuse of "site-packages/tests" directory. The other two packages are python-fs and afl-utils. See ArchLinux bug report: https://bugs.archlinux.org/task/52194

I believe, that oauth2client should either not install this tests directory as part of install script or use less generic name. From package maintainer point of view, we have three options:

  1. remove "site-packages/tests" after installation (I'm not fan of modifying upstream sources)
  2. label the packages as conflicting so no one will be able to install them at the same time (seems not good, as tests are only conflict here!)
  3. could be creation of meta-package with shared content (but the files differ in content, so it's not an option).

As a temporary workaround I can only apply solution "1" as maintainer of afl-utils did, but I think this should be resolved upstream.

Cheers,
Andrzej.

@ncouture
Copy link

ncouture commented Jan 31, 2017

I was able to reproduce this when using the same setup.py install arguments you are using in your package's build script (notably --root). This does not happen when --root is passed without --skip-build which is what your build script does, or when setup.py is invoked with the install argument alone.

What you describe seems to be a problem encountered by other Arch Python lib packagers, maybe they can shed some light on how they solved this issue.

@theacodes
Copy link
Contributor

We just need to update two things:

  1. Include tests in manifest.in
  2. Add exclude=('tests',) to find_packages() in setup.py.

If either of you wanna send a PR I'll be happy to review it, but I don't have time to make this (albeit trivial) change this week.

strigazi added a commit to strigazi/oauth2client that referenced this issue Jun 29, 2017
To avoid conflicts with projects that have tests in their top-level
directory:

* exlude tests in find_packages
* add include in MANIFEST.in

Closes: googleapis#688

Signed-off-by: Spyros Trigazis <spyridon.trigazis@cern.ch>
strigazi added a commit to strigazi/oauth2client that referenced this issue Jun 29, 2017
To avoid conflicts with projects that have tests in their top-level
directory:

* exlude tests in find_packages
* add include in MANIFEST.in

Closes: googleapis#688

Signed-off-by: Spyros Trigazis <spyridon.trigazis@cern.ch>
strigazi added a commit to strigazi/oauth2client that referenced this issue Jun 29, 2017
To avoid conflicts with projects that have tests in their top-level
directory:

* exlude tests in find_packages
* add include in MANIFEST.in

Closes: googleapis#688

Signed-off-by: Spyros Trigazis <strigazi@gmail.com>
theacodes pushed a commit that referenced this issue Jun 29, 2017
To avoid conflicts with projects that have tests in their top-level
directory:

* exlude tests in find_packages
* add include in MANIFEST.in

Closes: #688

Signed-off-by: Spyros Trigazis <strigazi@gmail.com>
openstack-gerrit pushed a commit to openstack/openstack that referenced this issue Jun 30, 2017
Project: openstack/requirements  8a2ba1c08cb9f20fe373c242b85d9e7b4255bfb3

Update oauth2client to 4.1.2

oauth2client upstream has recently released a new version 4.1.2
which fixes the conflicts in site-packages/tests issue[1.] (which
is breaking the rally-pep8 ci by causing the issue.). The above
version fixes the issue.

[1.] googleapis/oauth2client#688

Change-Id: I5489ee60cee9857036bb0796f56466cbbf1396c0
openstack-gerrit pushed a commit to openstack/requirements that referenced this issue Jun 30, 2017
oauth2client upstream has recently released a new version 4.1.2
which fixes the conflicts in site-packages/tests issue[1.] (which
is breaking the rally-pep8 ci by causing the issue.). The above
version fixes the issue.

[1.] googleapis/oauth2client#688

Change-Id: I5489ee60cee9857036bb0796f56466cbbf1396c0
openstack-gerrit pushed a commit to openstack/openstack that referenced this issue Jun 30, 2017
Project: openstack/requirements  8a2ba1c08cb9f20fe373c242b85d9e7b4255bfb3

Update oauth2client to 4.1.2

oauth2client upstream has recently released a new version 4.1.2
which fixes the conflicts in site-packages/tests issue[1.] (which
is breaking the rally-pep8 ci by causing the issue.). The above
version fixes the issue.

[1.] googleapis/oauth2client#688

Change-Id: I5489ee60cee9857036bb0796f56466cbbf1396c0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants