This repository has been archived by the owner on Dec 19, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 94
refactor(samples): convert sample tests from ava to mocha #133
Merged
JustinBeckwith
merged 12 commits into
googleapis:master
from
nareshqlogic:sample_ava_to_mocha
Nov 23, 2018
Merged
refactor(samples): convert sample tests from ava to mocha #133
JustinBeckwith
merged 12 commits into
googleapis:master
from
nareshqlogic:sample_ava_to_mocha
Nov 23, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Nov 15, 2018
JustinBeckwith
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Nov 16, 2018
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Nov 16, 2018
JustinBeckwith
suggested changes
Nov 16, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good except for the 2 comments :)
JustinBeckwith
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Nov 19, 2018
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Nov 19, 2018
JustinBeckwith
approved these changes
Nov 19, 2018
Looks like a few interesting test failures:
|
Hi @JustinBeckwith , |
JustinBeckwith
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Nov 20, 2018
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Nov 20, 2018
Sounds good to me, but we probably want to make sure it actually exists first, or wrap the unlink in a try/catch :)
|
Thank you Justin. I warped the unlink in a try/catch. |
JustinBeckwith
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Nov 22, 2018
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Nov 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes convert all sample tests from ava to mocha #2865 (it's a good idea to open an issue first for discussion)