Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commented value (missing quote) #2418

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

zinovik
Copy link
Contributor

@zinovik zinovik commented Mar 3, 2024

No description provided.

@zinovik zinovik requested review from a team as code owners March 3, 2024 07:07
Copy link

google-cla bot commented Mar 3, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/nodejs-storage API. labels Mar 3, 2024
@zinovik zinovik force-pushed the fix/commented-value branch 2 times, most recently from ef796d6 to a9ad23d Compare March 3, 2024 07:54
@ddelgrosso1
Copy link
Contributor

Hi @zinovik thank you for the contribution. Can you please accept / sign the CLA and also just update the commit message to use samples: instead of fix:.

@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 4, 2024
@zinovik zinovik force-pushed the fix/commented-value branch from a9ad23d to ef2b7ca Compare March 4, 2024 16:14
@zinovik
Copy link
Contributor Author

zinovik commented Mar 4, 2024

@ddelgrosso1 Done ;)

@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 4, 2024
@ddelgrosso1 ddelgrosso1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 4, 2024
@ddelgrosso1
Copy link
Contributor

Thanks again for the contribution @zinovik

@ddelgrosso1 ddelgrosso1 merged commit 55ff53b into googleapis:main Mar 4, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants