Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Base TPC Support #2397

Merged
merged 13 commits into from
Feb 12, 2024
Merged

feat: Base TPC Support #2397

merged 13 commits into from
Feb 12, 2024

Conversation

danielbankhead
Copy link
Member

@danielbankhead danielbankhead commented Jan 29, 2024 •
edited
Loading

Related: #2197

🦕

@danielbankhead danielbankhead requested review from a team as code owners January 29, 2024 20:05
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/nodejs-storage API. labels Jan 29, 2024
BrennaEpp
BrennaEpp reviewed Jan 29, 2024
View reviewed changes
Copy link

@BrennaEpp BrennaEpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see some tests around signed URLs, but that may or may not apply to this PR depending if I'm understanding it correctly. Left some questions to figure it out. Thanks!

src/signer.ts Outdated Show resolved Hide resolved
src/signer.ts Outdated Show resolved Hide resolved
ddelgrosso1
ddelgrosso1 reviewed Jan 29, 2024
View reviewed changes
src/file.ts
@@ -302,7 +312,7 @@ export enum ActionToHTTPMethod {
}

/**
* @private
* @deprecated - no longer used
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to fall under a breaking change since it is being deprecated in this feature?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest no since we've previously marked it as private

ddelgrosso1
ddelgrosso1 reviewed Jan 29, 2024
View reviewed changes
src/signer.ts
@@ -102,20 +111,17 @@ const SEVEN_DAYS = 7 * 24 * 60 * 60;

/**
* @const {string}
* @private
* @deprecated - unused
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as above

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jan 30, 2024
@danielbankhead
Copy link
Member Author

I'd like to see some tests around signed URLs, but that may or may not apply to this PR depending if I'm understanding it correctly. Left some questions to figure it out. Thanks!

Added some tests

@danielbankhead danielbankhead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 30, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 30, 2024
BrennaEpp
BrennaEpp reviewed Feb 7, 2024
View reviewed changes
src/file.ts Show resolved Hide resolved
@danielbankhead
chore: Bump google-auth-library
fcf3b6c 
9.6.3+ is required for Storage TPC Support
@danielbankhead danielbankhead merged commit a3f4891 into main Feb 12, 2024
19 checks passed
@danielbankhead danielbankhead deleted the tpc-updates branch February 12, 2024 22:10
@release-please release-please bot mentioned this pull request Feb 12, 2024
Merged
@50Fifty 50Fifty mentioned this pull request May 23, 2024
Open
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 19, 2024
Open
This was referenced Jul 16, 2024
Open
Open
@snyk-io snyk-io bot mentioned this pull request Jul 16, 2024
Open
@WontonSam WontonSam mentioned this pull request Jul 16, 2024
Open
@polly-parrot polly-parrot mentioned this pull request Aug 3, 2024
Open
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 9, 2024
Open
This was referenced Aug 14, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddelgrosso1 ddelgrosso1 ddelgrosso1 left review comments

@BrennaEpp BrennaEpp BrennaEpp approved these changes

@JesseLovelace JesseLovelace JesseLovelace approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danielbankhead @BrennaEpp @JesseLovelace @ddelgrosso1 @yoshi-kokoro