Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly handle if a user has no permissions when calling iam.t… #2140

Merged
merged 1 commit into from
Feb 6, 2023
Merged

fix: correctly handle if a user has no permissions when calling iam.t… #2140

merged 1 commit into from
Feb 6, 2023

Conversation

ddelgrosso1
Copy link
Contributor

…estPermissions

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2139 🦕

@ddelgrosso1 ddelgrosso1 requested review from a team as code owners February 2, 2023 15:26
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/nodejs-storage API. labels Feb 2, 2023
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 2, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 2, 2023
shaffeeullah
shaffeeullah approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@shaffeeullah shaffeeullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, denis!!

qw-in
qw-in approved these changes Feb 6, 2023
View reviewed changes
Copy link

@qw-in qw-in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix 👍

@ddelgrosso1 ddelgrosso1 merged commit cce902d into googleapis:main Feb 6, 2023
@ddelgrosso1 ddelgrosso1 deleted the fix-test-iam-perms branch February 6, 2023 14:12
@release-please release-please bot mentioned this pull request Feb 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw-in qw-in qw-in approved these changes

@shaffeeullah shaffeeullah shaffeeullah approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bucket.iam.testPermissions can kill process
3 participants
@ddelgrosso1 @qw-in @shaffeeullah