Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document DownscopedClient Usage #1797

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Conversation

danielbankhead
Copy link
Contributor

@danielbankhead danielbankhead requested review from a team as code owners February 22, 2022 22:04
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Feb 22, 2022
@ddelgrosso1
Copy link
Contributor

No objection to this PR but this looks like something we should probably further document in a sample at some point in the near future.

@ddelgrosso1 ddelgrosso1 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 22, 2022
@ddelgrosso1
Copy link
Contributor

Added 'do not merge' until common is released.

@danielbankhead
Copy link
Contributor Author

danielbankhead commented Feb 22, 2022

No objection to this PR but this looks like something we should probably further document in a sample at some point in the near future.

I think it's fair to add the sample to this PR; makes the resolution a bit more comprehensive. I'll add it once common is updated

@danielbankhead danielbankhead removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 23, 2022
@danielbankhead
Copy link
Contributor Author

Offline update: We'll need to sync with the rest of the team on rolling out DownscopedClient for Storage samples to the other langs. Will merge this now, pending a sample directly in this repo in the future. In the meantime, these will suffice for Node.js for now:

@danielbankhead danielbankhead merged commit e9cce0d into main Feb 23, 2022
@danielbankhead danielbankhead deleted the downscope-token-support branch February 23, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to use a CredentialAccessBoundary/DownscopedToken
3 participants