Skip to content

Commit

Permalink
refactor: remove usage of async module (#702)
Browse files Browse the repository at this point in the history
  • Loading branch information
AVaksman authored and JustinBeckwith committed May 9, 2019
1 parent 42937a8 commit c94cc72
Show file tree
Hide file tree
Showing 3 changed files with 304 additions and 587 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@
"@google-cloud/paginator": "^1.0.0",
"@google-cloud/promisify": "^1.0.0",
"arrify": "^2.0.0",
"async": "^2.0.1",
"compressible": "^2.0.12",
"concat-stream": "^2.0.0",
"date-and-time": "^0.6.3",
Expand Down Expand Up @@ -107,6 +106,7 @@
"node-fetch": "^2.2.0",
"normalize-newline": "^3.0.0",
"nyc": "^14.0.0",
"p-limit": "^2.2.0",
"power-assert": "^1.4.4",
"prettier": "^1.7.0",
"proxyquire": "^2.0.0",
Expand Down
6 changes: 3 additions & 3 deletions src/bucket.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1099,7 +1099,7 @@ class Bucket extends ServiceObject {
combine(
sources: string[] | File[],
destination: string | File,
options: CombineOptions
options?: CombineOptions
): Promise<CombineResponse>;
combine(
sources: string[] | File[],
Expand Down Expand Up @@ -2773,7 +2773,7 @@ class Bucket extends ServiceObject {

setStorageClass(
storageClass: string,
options: SetBucketStorageClassOptions
options?: SetBucketStorageClassOptions
): Promise<SetBucketMetadataResponse>;
setStorageClass(
storageClass: string,
Expand Down Expand Up @@ -2827,7 +2827,7 @@ class Bucket extends ServiceObject {
*/
setStorageClass(
storageClass: string,
optionsOrCallback:
optionsOrCallback?:
| SetBucketStorageClassOptions
| SetBucketStorageClassCallback,
callback?: SetBucketStorageClassCallback
Expand Down
Loading

0 comments on commit c94cc72

Please sign in to comment.