chore!: make node 14 the minimum version (#2230)

* chore!: make node 14 the minimum version

* move conformance test to node 14

* package upgrades, fix unit test compilation

* update google owned deps

* fix tests

* remove node 12 kokoro folders

.github/sync-repo-settings.yaml

@@ -14,9 +14,9 @@ branchProtectionRules:
       - "ci/kokoro: System test"
       - docs
       - lint
-      - test (12)
       - test (14)
       - test (16)
+      - test (18)
       - cla/google
       - windows
       - OwlBot Post Processor

.github/workflows/ci.yaml

@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [12, 14, 16]
+        node: [14, 16, 18]
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3

.github/workflows/conformance-test.yaml

@@ -11,7 +11,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 12
+          node-version: 14
       - run: node --version
       - run: npm install
       - run: npm run conformance-test

package.json

@@ -5,7 +5,7 @@
   "license": "Apache-2.0",
   "author": "Google Inc.",
   "engines": {
-    "node": ">=12"
+    "node": ">=14"
   },
   "repository": "googleapis/nodejs-storage",
   "main": "./build/src/index.js",
@@ -58,13 +58,13 @@
     "compressible": "^2.0.12",
     "duplexify": "^4.0.0",
     "ent": "^2.2.0",
-    "gaxios": "^5.1.2",
-    "google-auth-library": "^8.0.1",
+    "gaxios": "^6.0.2",
+    "google-auth-library": "^9.0.0",
     "mime": "^3.0.0",
     "mime-types": "^2.0.8",
     "p-limit": "^3.0.1",
-    "retry-request": "^5.0.0",
-    "teeny-request": "^8.0.0",
+    "retry-request": "^6.0.0",
+    "teeny-request": "^9.0.0",
     "uuid": "^8.0.0"
   },
   "devDependencies": {
@@ -78,17 +78,17 @@
     "@types/mime-types": "^2.1.0",
     "@types/mocha": "^9.1.1",
     "@types/mockery": "^1.4.29",
-    "@types/node": "^18.0.0",
+    "@types/node": "^20.4.4",
     "@types/node-fetch": "^2.1.3",
     "@types/proxyquire": "^1.3.28",
     "@types/request": "^2.48.4",
-    "@types/sinon": "^10.0.0",
+    "@types/sinon": "^10.0.15",
     "@types/tmp": "0.2.3",
     "@types/uuid": "^8.0.0",
     "@types/yargs": "^17.0.10",
     "c8": "^8.0.0",
     "form-data": "^4.0.0",
-    "gts": "^3.1.0",
+    "gts": "^3.1.1",
     "jsdoc": "^4.0.0",
     "jsdoc-fresh": "^2.0.0",
     "jsdoc-region-tag": "^2.0.0",
@@ -98,9 +98,9 @@
     "nock": "~13.3.0",
     "node-fetch": "^2.6.7",
     "proxyquire": "^2.1.3",
-    "sinon": "^15.0.0",
+    "sinon": "^15.2.0",
     "tmp": "^0.2.0",
-    "typescript": "^4.6.4",
+    "typescript": "^5.1.6",
     "yargs": "^17.3.1"
   }
 }

test/resumable-upload.ts

@@ -1618,7 +1618,7 @@ describe('resumable-upload', () => {
       const scope = nock(REQ_OPTS.url!).get(queryPath).reply(500, {error});
       await assert.rejects(up.makeRequest(REQ_OPTS), (err: GaxiosError) => {
         scope.done();
-        assert.strictEqual(err.code, '500');
+        assert.strictEqual(err.status, 500);
         return true;
       });
     });
@@ -1635,7 +1635,7 @@ describe('resumable-upload', () => {
       const scope = nock(REQ_OPTS.url!).get(queryPath).reply(500, {error});
       await assert.rejects(up.makeRequest(REQ_OPTS), (err: GaxiosError) => {
         scope.done();
-        assert.deepStrictEqual(err.code, '500');
+        assert.deepStrictEqual(err.status, 500);
         return true;
       });
     });