use assert.rejects

system-test/storage.ts

@@ -1788,7 +1788,7 @@ describe('storage', () => {
         type requesterPaysFunction<
           T = {} | typeof USER_PROJECT_OPTIONS,
           R = {} | void,
-        > = (options: T) => Promise<R>;
+        > = (options?: T) => Promise<R>;
 
         /**
          * Accepts a function and runs 2 tests - a test where the requester pays
@@ -1805,21 +1805,16 @@ describe('storage', () => {
           const failureMessage =
             'Bucket is a requester pays bucket but no user project provided.';
 
-          let expectedError: unknown = null;
-
-          try {
-            // Should raise an error on requester pays bucket
-            await testFunction({});
-          } catch (e) {
-            expectedError = e;
-          }
-
-          console.log(JSON.stringify(expectedError));
-          assert(expectedError instanceof Error);
-          assert(
-            expectedError.message.includes(failureMessage),
-            `Expected '${expectedError.message}' to include '${failureMessage}'`
-          );
+          await assert.rejects(testFunction(), err => {
+            console.log(JSON.stringify(err));
+            console.log('');
+            assert(
+              (err as Error).message.includes(failureMessage),
+              `Expected '${
+                (err as Error).message
+              }' to include '${failureMessage}'`
+            );
+          });
 
           // Validate the desired functionality
           const results = await testFunction(USER_PROJECT_OPTIONS);