Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(typescript): noImplicityAny for index.ts #482

Merged

Conversation

praveenqlogic
Copy link
Contributor

Fixes #313 (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 15, 2019
@praveenqlogic
Copy link
Contributor Author

locally both ('should get a list of snapshots','should get a list of snapshots as a stream') test case is passing.

@JustinBeckwith
Copy link
Contributor

👋 @callmehiphop looks like another potential case of a flake

@codecov
Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #482 into master will decrease coverage by 0.25%.
The diff coverage is 91.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
- Coverage   95.11%   94.85%   -0.26%     
==========================================
  Files          15       15              
  Lines         982      991       +9     
  Branches       73       83      +10     
==========================================
+ Hits          934      940       +6     
  Misses         43       43              
- Partials        5        8       +3
Impacted Files Coverage Δ
src/message-stream.ts 100% <ø> (ø) ⬆️
src/index.ts 100% <100%> (ø) ⬆️
src/message-queues.ts 100% <100%> (ø) ⬆️
src/topic.ts 91.86% <62.5%> (-3.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e59f8ec...84533b4. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit 8a0e711 into googleapis:master Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants